public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <jh@suse.cz>
To: Richard Kenner <kenner@vlsi1.ultra.nyu.edu>
Cc: jh@suse.cz, gcc-patches@gcc.gnu.org
Subject: Re: spec2000 regression
Date: Wed, 15 Aug 2001 06:03:00 -0000	[thread overview]
Message-ID: <20010815150251.Y19872@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <10108151302.AA17923@vlsi1.ultra.nyu.edu>

>     the problem is that actually code first sets the DECL_RTL and then
>     calls set_mem_attributes, that calls get_alias_set, but it thinks that
>     the alias set is already computed, but it isn't.
> 
>     I am now testing following patch. OK to install if it succeeds?
> 
> I'd prefer to fix things so they don't set DECL_RTL first.  MEM_ALIAS_SET
> is not a test to see if the alias set has been set.  The alias set might
> have been zero in which case we *do* want to use it.
That what I was trying to do first, but there are number of places this
is happening and fixing each of it still keeps open door for possible
new bugs - it is natural to save the RTL to proper place first.

If I understand the purpose of original patch properly, it was hooting for
case variable gets unique class, but this class is recomputed several times
so it get several unique classes.
For class 0 this does not matter.

Honza
> 
> So I think your change is wrong.

  reply	other threads:[~2001-08-15  6:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-15  5:57 Richard Kenner
2001-08-15  6:03 ` Jan Hubicka [this message]
2001-08-15  6:36   ` Jason Merrill
2001-08-15  6:52     ` Jan Hubicka
2001-08-15  7:11       ` Jason Merrill
2001-08-15  7:13         ` Jan Hubicka
2001-08-15  7:36         ` Jan Hubicka
2001-08-15  8:04         ` Mark Mitchell
2001-08-16  5:58           ` Jan Hubicka
2001-08-16  6:09             ` Jason Merrill
2001-08-16  7:40               ` Jan Hubicka
2001-08-16  7:46                 ` Jason Merrill
  -- strict thread matches above, loose matches on Subject: below --
2001-08-15 11:28 Richard Kenner
2001-08-16  6:09 ` Jason Merrill
2001-08-22  7:53   ` Jason Merrill
2001-08-15  7:08 Richard Kenner
2001-08-15  7:10 ` Jan Hubicka
     [not found] <20010815123730.P19872@atrey.karlin.mff.cuni.cz>
     [not found] ` <m366bpsi91.fsf@prospero.cambridge.redhat.com>
2001-08-15  5:41   ` Jan Hubicka
2001-08-15  6:18     ` Jason Merrill
2001-08-15  6:40     ` Joseph S. Myers
2001-08-15  7:36       ` Jan Hubicka
2001-08-15  7:44         ` Joseph S. Myers
2001-08-15 11:04           ` Andreas Jaeger
2001-08-15  7:56     ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010815150251.Y19872@atrey.karlin.mff.cuni.cz \
    --to=jh@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kenner@vlsi1.ultra.nyu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).