public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <jh@suse.cz>
To: Jason Merrill <jason_merrill@redhat.com>
Cc: Jan Hubicka <jh@suse.cz>,
	Richard Kenner <kenner@vlsi1.ultra.nyu.edu>,
	gcc-patches@gcc.gnu.org
Subject: Re: spec2000 regression
Date: Wed, 15 Aug 2001 06:52:00 -0000	[thread overview]
Message-ID: <20010815155130.J19872@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <m3hev9qwc1.fsf@prospero.cambridge.redhat.com>

bad style or not, I believe it would be somewhat dificult to avoid getting it into
gcc. Such bugs can be dificult to find, as they waste only the performance.
Thanks Andreas for his automated tester :)
> 
> On the contrary, it is needed for the case where a variable gets a class
> different from that of its type, so recomputing it would give the wrong
> answer.  How does this work for you?
> 
> 2001-08-15  Jason Merrill  <jason_merrill@redhat.com>
> 
> 	* varasm.c (make_decl_rtl): Don't SET_DECL_RTL until we're done
> 	modifying the rtl.
> 
Yes, I've made the same patch before the one I sent to list and it solves
this particular problem.
Note that function.c contains other similar code - just take a look for
set_memory_attributes calls contains DECL_RTL in the argument.

Honza


  reply	other threads:[~2001-08-15  6:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-15  5:57 Richard Kenner
2001-08-15  6:03 ` Jan Hubicka
2001-08-15  6:36   ` Jason Merrill
2001-08-15  6:52     ` Jan Hubicka [this message]
2001-08-15  7:11       ` Jason Merrill
2001-08-15  7:13         ` Jan Hubicka
2001-08-15  7:36         ` Jan Hubicka
2001-08-15  8:04         ` Mark Mitchell
2001-08-16  5:58           ` Jan Hubicka
2001-08-16  6:09             ` Jason Merrill
2001-08-16  7:40               ` Jan Hubicka
2001-08-16  7:46                 ` Jason Merrill
  -- strict thread matches above, loose matches on Subject: below --
2001-08-15 11:28 Richard Kenner
2001-08-16  6:09 ` Jason Merrill
2001-08-22  7:53   ` Jason Merrill
2001-08-15  7:08 Richard Kenner
2001-08-15  7:10 ` Jan Hubicka
     [not found] <20010815123730.P19872@atrey.karlin.mff.cuni.cz>
     [not found] ` <m366bpsi91.fsf@prospero.cambridge.redhat.com>
2001-08-15  5:41   ` Jan Hubicka
2001-08-15  6:18     ` Jason Merrill
2001-08-15  6:40     ` Joseph S. Myers
2001-08-15  7:36       ` Jan Hubicka
2001-08-15  7:44         ` Joseph S. Myers
2001-08-15 11:04           ` Andreas Jaeger
2001-08-15  7:56     ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010815155130.J19872@atrey.karlin.mff.cuni.cz \
    --to=jh@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason_merrill@redhat.com \
    --cc=kenner@vlsi1.ultra.nyu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).