From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Berlin To: Jakub Jelinek Cc: , Subject: Re: Unreviewed patches Date: Mon, 12 Nov 2001 12:40:00 -0000 Message-ID: References: <20011112094646.O4087@devserv.devel.redhat.com> X-SW-Source: 2001-11.2/msg00830.html Message-ID: <20011112124000._Au4ohhxv6sN3OP2ANgotF1NLItcloezuzYn6UXD-GU@z> On Mon, 12 Nov 2001, Jakub Jelinek wrote: > Hi! > > http://gcc.gnu.org/ml/gcc-patches/2001-10/msg01300.html > - fix endless loop with bogus C array initializer > http://gcc.gnu.org/ml/gcc-patches/2001-10/msg00898.html > - fix ICE handling anonymous union on Alpha/Sparc/... > http://gcc.gnu.org/ml/gcc-patches/2001-10/msg01218.html > - fix store motion (although Dan Berlin claims > store motion should be disabled altogether ATM, > IMHO this patch should be applied nevertheless) I agree, BTW, as it's *part* of a correct fix, but nowhere near complete. The list of problems with store motion, off the top of my head: 1. store_ops_ok returns the opposite value it should (IE 0 when should be 1, 1 when should be 0) for registers. 2. Constant calls are not handled properly. 3. memory that can alias anything is not handled properly (it doesn't notice that stores that alias anything kill your current store, as well as loads from memory that alias anything) These are just the bugs off the top of my head, while trying to pay attention in criminal law class. --Dan