public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: <guerby@acm.org>
To: dave@hiauly1.hia.nrc.ca
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Ada] Trivial fix for warning in utils.c
Date: Tue, 13 Nov 2001 15:03:00 -0000	[thread overview]
Message-ID: <200111161935.fAGJZTf17398@ulmo.localdomain> (raw)
In-Reply-To: <200111161928.fAGJSW44010685@hiauly1.hia.nrc.ca> (dave@hiauly1.hia.nrc.ca)

> All the functions in the file use KR style.  The function actually needs
> a prototype.  There is one in misc.c but that is rather a strange place
> for it.

Not true, I checked to see wether void was already used and found:

void
end_subprog_body (void)

Looking in other ada/*.c files both style are used (PARAMS((void)) vs (void)).
It would be trivial to move to one or another. Richard, should I test and submit
a patch moving to one of those style (and which one)?

BTW, do the ada/*.c file use C features not supported by your average
K&R compiler? (Giving a false sense of K&R'ness makes no good IMHO.)

-- 
Laurent Guerby <guerby@acm.org>

  reply	other threads:[~2001-11-16 19:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-13 15:03 John David Anglin
2001-11-13 15:03 ` guerby [this message]
2001-11-13 15:03   ` Neil Booth
2001-11-13 15:03     ` Florian Weimer
2001-11-13 15:03 Richard Kenner
2001-11-13 15:03 Richard Kenner
2001-11-13 15:03 Richard Kenner
2001-11-13 15:03 Richard Kenner
2001-11-13 15:03 ` guerby
2001-11-13 15:03 guerby
2001-11-13 15:03 ` Graham Stott
2001-11-13 15:03   ` guerby
2001-11-13 15:03     ` Florian Weimer
2001-11-13 15:03     ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200111161935.fAGJZTf17398@ulmo.localdomain \
    --to=guerby@acm.org \
    --cc=dave@hiauly1.hia.nrc.ca \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).