From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5614 invoked by alias); 16 Nov 2001 19:38:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5460 invoked from network); 16 Nov 2001 19:38:14 -0000 Received: from unknown (HELO anagyris.wanadoo.fr) (193.252.19.151) by sourceware.cygnus.com with SMTP; 16 Nov 2001 19:38:14 -0000 Received: from mel-rta7.wanadoo.fr (193.252.19.61) by anagyris.wanadoo.fr; 16 Nov 2001 20:38:13 +0100 Received: from ulmo.localdomain (193.251.50.169) by mel-rta7.wanadoo.fr; 16 Nov 2001 20:37:50 +0100 Received: (from guerby@localhost) by ulmo.localdomain (8.11.6/8.11.6) id fAGJZTf17398; Fri, 16 Nov 2001 20:35:29 +0100 Date: Tue, 13 Nov 2001 15:03:00 -0000 Message-Id: <200111161935.fAGJZTf17398@ulmo.localdomain> X-Authentication-Warning: ulmo.localdomain: guerby set sender to guerby@acm.org using -f From: To: dave@hiauly1.hia.nrc.ca CC: gcc-patches@gcc.gnu.org In-reply-to: <200111161928.fAGJSW44010685@hiauly1.hia.nrc.ca> (dave@hiauly1.hia.nrc.ca) Subject: Re: [Ada] Trivial fix for warning in utils.c Reply-to: guerby@acm.org References: <200111161928.fAGJSW44010685@hiauly1.hia.nrc.ca> X-SW-Source: 2001-11/txt/msg00385.txt.bz2 > All the functions in the file use KR style. The function actually needs > a prototype. There is one in misc.c but that is rather a strange place > for it. Not true, I checked to see wether void was already used and found: void end_subprog_body (void) Looking in other ada/*.c files both style are used (PARAMS((void)) vs (void)). It would be trivial to move to one or another. Richard, should I test and submit a patch moving to one of those style (and which one)? BTW, do the ada/*.c file use C features not supported by your average K&R compiler? (Giving a false sense of K&R'ness makes no good IMHO.) -- Laurent Guerby