From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25903 invoked by alias); 16 Jan 2002 17:49:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25810 invoked from network); 16 Jan 2002 17:49:43 -0000 Received: from unknown (HELO atrey.karlin.mff.cuni.cz) (195.113.31.123) by sources.redhat.com with SMTP; 16 Jan 2002 17:49:43 -0000 Received: (from hubicka@localhost) by atrey.karlin.mff.cuni.cz (8.9.3/8.9.3/Debian 8.9.3-21) id SAA29830; Wed, 16 Jan 2002 18:48:24 +0100 Date: Wed, 16 Jan 2002 09:58:00 -0000 From: Jan Hubicka To: John David Anglin Cc: Jan Hubicka , gcc-bugs@gcc.gnu.org, rth@redhat.com, gcc-patches@gcc.gnu.org Subject: Re: PATCH: Re: ICE in 920624-1.c with -O3 -funroll-loops on vax-dec-ultrix4.3 Message-ID: <20020116174824.GB26411@atrey.karlin.mff.cuni.cz> References: <20020116164336.GC14914@atrey.karlin.mff.cuni.cz> <200201161708.g0GH86Md028855@hiauly1.hia.nrc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200201161708.g0GH86Md028855@hiauly1.hia.nrc.ca> User-Agent: Mutt/1.3.24i X-SW-Source: 2002-01/txt/msg01180.txt.bz2 > > My approach in the cfg is to keep the tables around and sweep them once done > > with CSE, but I guess it is easier to zap them to NOTE_INSN_DELETED_LABEL instead. > > I plan to do that move on the cfg branch. > > > > In your case all you need is to use delete_insn_chain for the two insns that > > cares to create the note instead. > > We have > > (jump (pc) (label_ref 1)) > > (code_label 1) > > (jump_insn (addr_diff_vec:HI (label_ref: 1) > ... > > You are suggesting deleting first two with NOTE_INSN_DELETED_LABEL? > Of course, this would be done only when the jump goes to the next insn. > This still leaves the jump table in live code which I don't like. No, just remove the second two using remove_insn_chain call - that should turn label to NOTE_INSN_DELETED_LABEL if it is still referenced and remove the jumptable - that should be what you are looking for. > > Another alternative might be to add a code_label after the jump table > and add a new jump before the first jump. This should make the three > insn dead. Would this be safer? That should work too, but it is bit complex. Honza > > Dave > -- > J. David Anglin dave.anglin@nrc.ca > National Research Council of Canada (613) 990-0752 (FAX: 952-6605)