From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31886 invoked by alias); 12 Jun 2002 17:23:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31876 invoked from network); 12 Jun 2002 17:23:06 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 12 Jun 2002 17:23:06 -0000 Received: from greed.delorie.com (cse.sfbay.redhat.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id KAA29863; Wed, 12 Jun 2002 10:23:02 -0700 (PDT) Received: (from dj@localhost) by greed.delorie.com (8.11.6/8.11.6) id g5CHMqe20664; Wed, 12 Jun 2002 13:22:52 -0400 Date: Wed, 12 Jun 2002 10:23:00 -0000 Message-Id: <200206121722.g5CHMqe20664@greed.delorie.com> From: DJ Delorie To: dave@hiauly1.hia.nrc.ca CC: gcc-patches@gcc.gnu.org, law@redhat.com, aoliva@redhat.com In-reply-to: <200206121703.g5CH3D9P026310@hiauly1.hia.nrc.ca> (dave@hiauly1.hia.nrc.ca) Subject: Re: Patch: Use tm_defines to configure default scheduling model on PA References: <200206121703.g5CH3D9P026310@hiauly1.hia.nrc.ca> X-SW-Source: 2002-06/txt/msg01119.txt.bz2 > > 2002-06-05 John David Anglin > > > > * Makefile.in (tm_defines): New configuration variable. > > (cs-config.h, cs-hconfig.h, cs-tconfig.h): Rename DEFINES to XM_DEFINES. > > Pass tm_defines in TM_DEFINES. > > (cs-tm_p.h): Rename DEFINES to XM_DEFINES. Pass TM_DEFINES. > > * config.gcc (tm_defines): New configuration variable. > > (hppa*-*-* | parisc*-*-*): Use tm_defines instead of pa-700.h and > > pa-7100.h headers. Change hppa1* scheduling default to 7100LC. > > * configure.in: Substitute tm_defines. > > * configure: Rebuilt. > > * mkconfig.sh: Rename DEFINES to XM_DEFINES. Output TM_DEFINES. > > * pa/pa-700.h: Delete file. > > * pa/pa-7100.h: Delete file. > > The above patch has not been reviewed. Could one of the build machinery > maintainers review it? Sorry I missed it, but the subject line was a bit misleading. The patch is fine. However, the PPC already has a way of selecting the default CPU (and thus scheduling etc) with a configure option and config.gcc. Did you look at that mechanism before implementing this one? And I predict that at some point in the future, there will be a thread about how all those defines in config.gcc are cluttering up the script, and why can't we put them all in target-specific headers?