From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14919 invoked by alias); 12 Jun 2002 17:51:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14896 invoked from network); 12 Jun 2002 17:51:09 -0000 Received: from unknown (HELO hiauly1.hia.nrc.ca) (132.246.100.193) by sources.redhat.com with SMTP; 12 Jun 2002 17:51:09 -0000 Received: from hiauly1.hia.nrc.ca (localhost [127.0.0.1]) by hiauly1.hia.nrc.ca (8.12.0.Beta16/8.12.0.Beta16) with ESMTP id g5CHp6FN026370 for ; Wed, 12 Jun 2002 13:51:07 -0400 (EDT) Received: (from dave@localhost) by hiauly1.hia.nrc.ca (8.12.0.Beta16/8.12.0.Beta16) id g5CHp5S6026368; Wed, 12 Jun 2002 13:51:05 -0400 (EDT) Message-Id: <200206121751.g5CHp5S6026368@hiauly1.hia.nrc.ca> Subject: Re: Patch: Use tm_defines to configure default scheduling model on PA To: dj@redhat.com (DJ Delorie) Date: Wed, 12 Jun 2002 10:51:00 -0000 From: "John David Anglin" Cc: gcc-patches@gcc.gnu.org, law@redhat.com, aoliva@redhat.com In-Reply-To: <200206121722.g5CHMqe20664@greed.delorie.com> from "DJ Delorie" at Jun 12, 2002 01:22:52 pm MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg01122.txt.bz2 > Sorry I missed it, but the subject line was a bit misleading. The > patch is fine. However, the PPC already has a way of selecting the > default CPU (and thus scheduling etc) with a configure option and > config.gcc. Did you look at that mechanism before implementing this > one? I did but I will look more closely at what ppc has done. > And I predict that at some point in the future, there will be a thread > about how all those defines in config.gcc are cluttering up the > script, and why can't we put them all in target-specific headers? The goal here was to eliminate small target-specific headers and provide a mechanism for selecting target options in the configuration process. At the moment, mkconfig.sh outputs DEFINES after HEADERS. I would argue that we should output DEFINES first so that they can be used to select build, host and target options in HEADERS and other code that includes the various config files. Placing the defines first allows defaults in the headers to be overriden. There were a number of comments after I submitted the patch that indicated the number of target-specific headers in the i386 config was too large and the inclusion process difficult to follow. Dave -- J. David Anglin dave.anglin@nrc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6605)