From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19910 invoked by alias); 12 Jun 2002 18:47:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19860 invoked from network); 12 Jun 2002 18:47:24 -0000 Received: from unknown (HELO hiauly1.hia.nrc.ca) (132.246.100.193) by sources.redhat.com with SMTP; 12 Jun 2002 18:47:24 -0000 Received: from hiauly1.hia.nrc.ca (localhost [127.0.0.1]) by hiauly1.hia.nrc.ca (8.12.0.Beta16/8.12.0.Beta16) with ESMTP id g5CIlMFN026450; Wed, 12 Jun 2002 14:47:22 -0400 (EDT) Received: (from dave@localhost) by hiauly1.hia.nrc.ca (8.12.0.Beta16/8.12.0.Beta16) id g5CIlLbJ026449; Wed, 12 Jun 2002 14:47:21 -0400 (EDT) Message-Id: <200206121847.g5CIlLbJ026449@hiauly1.hia.nrc.ca> Subject: Re: Patch: Use tm_defines to configure default scheduling model on PA To: dj@redhat.com (DJ Delorie) Date: Wed, 12 Jun 2002 11:47:00 -0000 From: "John David Anglin" Cc: gcc-patches@gcc.gnu.org, law@redhat.com, aoliva@redhat.com In-Reply-To: <200206121817.g5CIHBM21328@greed.delorie.com> from "DJ Delorie" at Jun 12, 2002 02:17:11 pm MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg01131.txt.bz2 > > that includes the various config files. Placing the defines first > > allows defaults in the headers to be overriden. > > Placing defines after allows you to redefine something with a simple > undef/define, without the main header needing to know that you're > doing it. There are cases that argue both ways, though. How does that work? mkconfig.sh doesn't do undef's. Although mkconfig.sh could be modified to undef/define when necessary, I still think it better to put the defines first because the headers may contain secondary defines based on the identifier that you want to redefine. Dave -- J. David Anglin dave.anglin@nrc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6605)