public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [RFC/A] gcc.dg/weak
@ 2002-07-29 11:01 David Edelsohn
  2002-07-29 16:45 ` Richard Henderson
  0 siblings, 1 reply; 6+ messages in thread
From: David Edelsohn @ 2002-07-29 11:01 UTC (permalink / raw)
  To: gcc-patches

	testsuite/gcc.dg currently has a number of tests for functionality
of weak symbols which do not respect whether the target supports weak
symbols.  I would like to move those tests to a "weak" subdirectory and
use the existing check_weak_available DejaGNU functionality to skip the
tests if the platform does not support weak.

Thanks, David


	* gcc.dg/weak: New directory.
	* gcc.dg/weak-[1-9]: Move to new directory.
	* gcc.dg/weak/weak.exp: New control file.


#   Copyright (C) 2002 Free Software Foundation, Inc.

# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
# 
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
# 
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  

# GCC testsuite that uses the `dg.exp' driver.

# Load support procs.
load_lib gcc-dg.exp

###############################
# proc gcc_target_object_format { }
###############################
# has been moved to:  gcc/testsuite/lib/file-format.exp

###############################
# proc check_weak_available { }
###############################
# has been moved to:  gcc/testsuite/lib/target-supports.exp

# If a testcase doesn't have special options, use these.
global DEFAULT_CFLAGS
if ![info exists DEFAULT_CFLAGS] then {
    set DEFAULT_CFLAGS " -ansi -pedantic-errors"
}

if { [ check_weak_available ] == 1 } {
    dg-init

    dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] \
            "" $DEFAULT_CFLAGS

    dg-finish
} elseif { [ check_weak_available ] == 0 } {
    unsupported "gcc.dg/weak"
} else {
    unresolved "gcc.dg/weak"
}

### EOF weak.exp

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC/A] gcc.dg/weak
  2002-07-29 11:01 [RFC/A] gcc.dg/weak David Edelsohn
@ 2002-07-29 16:45 ` Richard Henderson
  2002-07-29 19:47   ` David Edelsohn
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Henderson @ 2002-07-29 16:45 UTC (permalink / raw)
  To: David Edelsohn; +Cc: gcc-patches

On Mon, Jul 29, 2002 at 01:21:24PM -0400, David Edelsohn wrote:
> 	* gcc.dg/weak: New directory.
> 	* gcc.dg/weak-[1-9]: Move to new directory.
> 	* gcc.dg/weak/weak.exp: New control file.

Sure.  IIRC, there are a number of other tests that require
weak support and currently have large dejagnu hackery in each.


r~

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC/A] gcc.dg/weak
  2002-07-29 16:45 ` Richard Henderson
@ 2002-07-29 19:47   ` David Edelsohn
  0 siblings, 0 replies; 6+ messages in thread
From: David Edelsohn @ 2002-07-29 19:47 UTC (permalink / raw)
  To: Richard Henderson; +Cc: gcc-patches

>>>>> Richard Henderson writes:

Richard> Sure.  IIRC, there are a number of other tests that require
Richard> weak support and currently have large dejagnu hackery in each.

	There are other tests that check weak aliases, but not weak
symbols themselves.  We can check for alias support to test those.

David

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [RFC/A] gcc.dg/weak
@ 2002-09-01 17:57 Billinghurst, David (CRTS)
  0 siblings, 0 replies; 6+ messages in thread
From: Billinghurst, David (CRTS) @ 2002-09-01 17:57 UTC (permalink / raw)
  To: David Edelsohn; +Cc: gcc-patches

I have tested  this patch on irix (which support weak symbols) and
cygwin (which doesn't).  Works on both.  

-----Original Message-----
From: David Edelsohn [mailto:dje@watson.ibm.com]
Sent: Friday, 30 August 2002 1:59 
To: Billinghurst, David (CRTS)
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [RFC/A] gcc.dg/weak 


>>>>> Billinghurst, David (CRTS) writes:

David> What is the status of your gcc.dg/weak patches 
David> http://gcc.gnu.org/ml/gcc-patches/2002-07/msg01701.html

David> They look a better solution than more case-by-case hackery.
David> If they are acceptable but time is a problem I may be 
David> able to help.  

	I just haven't had a chance to test it more thoroughly to install
it.  Do you want to test it?

David

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC/A] gcc.dg/weak
  2002-08-29 20:58 Billinghurst, David (CRTS)
@ 2002-08-29 21:01 ` David Edelsohn
  0 siblings, 0 replies; 6+ messages in thread
From: David Edelsohn @ 2002-08-29 21:01 UTC (permalink / raw)
  To: Billinghurst, David (CRTS); +Cc: gcc-patches

>>>>> Billinghurst, David (CRTS) writes:

David> What is the status of your gcc.dg/weak patches 
David> http://gcc.gnu.org/ml/gcc-patches/2002-07/msg01701.html

David> They look a better solution than more case-by-case hackery.
David> If they are acceptable but time is a problem I may be 
David> able to help.  

	I just haven't had a chance to test it more thoroughly to install
it.  Do you want to test it?

David

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC/A] gcc.dg/weak
@ 2002-08-29 20:58 Billinghurst, David (CRTS)
  2002-08-29 21:01 ` David Edelsohn
  0 siblings, 1 reply; 6+ messages in thread
From: Billinghurst, David (CRTS) @ 2002-08-29 20:58 UTC (permalink / raw)
  To: gcc-patches; +Cc: dje

David,

What is the status of your gcc.dg/weak patches 
http://gcc.gnu.org/ml/gcc-patches/2002-07/msg01701.html

They look a better solution than more case-by-case hackery.
If they are acceptable but time is a problem I may be 
able to help.  

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2002-09-02  0:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-07-29 11:01 [RFC/A] gcc.dg/weak David Edelsohn
2002-07-29 16:45 ` Richard Henderson
2002-07-29 19:47   ` David Edelsohn
2002-08-29 20:58 Billinghurst, David (CRTS)
2002-08-29 21:01 ` David Edelsohn
2002-09-01 17:57 Billinghurst, David (CRTS)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).