From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21826 invoked by alias); 31 Jul 2002 13:24:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21810 invoked from network); 31 Jul 2002 13:24:28 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 31 Jul 2002 13:24:28 -0000 Received: from dsl254-114-118.nyc1.dsl.speakeasy.net ([216.254.114.118] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17ZtSo-0007iY-00; Wed, 31 Jul 2002 08:24:30 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17ZtSm-0007Qa-00; Wed, 31 Jul 2002 09:24:28 -0400 Date: Wed, 31 Jul 2002 06:41:00 -0000 From: Daniel Jacobowitz To: Richard Sandiford Cc: gcc-patches@sources.redhat.com, echristo@redhat.com Subject: Re: RFC: New approach to --with-cpu Message-ID: <20020731132428.GA28270@nevyn.them.org> Mail-Followup-To: Richard Sandiford , gcc-patches@sources.redhat.com, echristo@redhat.com References: <20020730215824.GA21681@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2002-07/txt/msg01863.txt.bz2 On Wed, Jul 31, 2002 at 02:15:53PM +0100, Richard Sandiford wrote: > Daniel Jacobowitz writes: > > +#ifdef TARGET_DEFAULT_OPTION_ARCH > > + if (! option_present (*argcp, *argvp, "-march=")) > > + add_option (argcp, argvp, "-march=" XSTRING (TARGET_DEFAULT_OPTION_ARCH)); > > +#endif > > On mips, what should happen if you give -mips3 on the command line? > Should it override the default -march? Seems like the default would > win as things stand. > > I suppose you could have: > > if (!option_present (*argcp, *argvp, "-march=") > && (!option_present (*argcp, *argvp, "-mips") > || option_present (*argcp, *argvp, "-mips16"))) > add_option (argcp, argvp, "-march=" XSTRING (TARGET_DEFAULT_OPTION_ARCH)); > > (since -mips16 shouldn't change the default arch) but maybe > there needs to be some sort of target macro? That doesn't do quite the right thing, if you think about the logic. It'd have to be "-mips1" or "-mips2" or "-mips3" or "-mips4" or "-mips5" (?) or "-mips32" or "-mips64". At this point there should obviously be a target macro, which I was hoping to avoid, but at least it can be a bit simpler. Blast it, I knew the maze of twisty MIPS command line options was going to bite me. I'll resubmit the patch with a target macro for this, then. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer