[PATCH, arm] Fix XFAIL in gcc.c-torture/execute/941014-1.x

[PATCH, arm] Fix XFAIL in gcc.c-torture/execute/941014-1.x

[Adam Nemet]

Hi,

This testcase used to be an XFAIL for thumb-*-elf.  Now that thumb-elf
has been deprecated, this fix modifies the testcase, so that now we
XFAIL for arm-*-elf/-mthumb with -O0.  (With -O1 and above the
testcase passes since addr2 is eliminated and is replaced with addr1.)

This patch was reg-tested together with my previous patch on
arm-sim/-mthumb: gcc.c-torture/execute/941014-1.c -O0 execution is now
an XFAIL.

Please apply if OK.

Adam

testsuite/ChangeLog:

2002-10-29  Adam Nemet  <anemet@lnxw.com>

	* gcc.c-torture/execute/941014-1.x: thumb-elf was deprecated, use
	-mthumb.  Only xfail with -O0.

Index: 941014-1.x
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/execute/941014-1.x,v
retrieving revision 1.2
diff -c -r1.2 941014-1.x
*** 941014-1.x	16 Dec 1998 22:13:15 -0000	1.2
--- 941014-1.x	30 Oct 2002 04:08:51 -0000
***************
*** 1,6 ****
! # This doesn't work for thumb-elf
   
! if { [istarget "thumb-*-elf"] } {
!         set torture_execute_xfail "thumb-*-elf"
  }
  return 0
--- 1,15 ----
! # This doesn't always work for Thumb.
   
! if { [istarget arm-*-elf] } {
!     set torture_eval_before_execute {
! 	global compiler_conditional_xfail_data
! 	set compiler_conditional_xfail_data {
! 	    "Thumb sets the last bit of function relocations" \
! 		    "arm-*-elf" \
! 		    { { "-mthumb" "-O0" } } \
! 		    { "" }
! 	}
!     }
  }
+ 
  return 0

Re: [PATCH, arm] Fix XFAIL in gcc.c-torture/execute/941014-1.x

[Richard Earnshaw]

> ! # This doesn't always work for Thumb.
>    
> ! if { [istarget arm-*-elf] } {
> !     set torture_eval_before_execute {
> ! 	global compiler_conditional_xfail_data
> ! 	set compiler_conditional_xfail_data {
> ! 	    "Thumb sets the last bit of function relocations" \
> ! 		    "arm-*-elf" \
> ! 		    { { "-mthumb" "-O0" } } \
> ! 		    { "" }

You need to test for any ARM target (elf, coff, aout plus various OS 
versions -- it's easier to just check for arm*-*-*), plus StrongArm and 
XScale.

R.

Re: [PATCH, arm] Fix XFAIL in gcc.c-torture/execute/941014-1.x

[Adam Nemet]

> > ! # This doesn't always work for Thumb.
> >    
> > ! if { [istarget arm-*-elf] } {
> > !     set torture_eval_before_execute {
> > ! 	global compiler_conditional_xfail_data
> > ! 	set compiler_conditional_xfail_data {
> > ! 	    "Thumb sets the last bit of function relocations" \
> > ! 		    "arm-*-elf" \
> > ! 		    { { "-mthumb" "-O0" } } \
> > ! 		    { "" }
> 
> You need to test for any ARM target (elf, coff, aout plus various OS 
> versions -- it's easier to just check for arm*-*-*), plus StrongArm and 
> XScale.

How about this one?

testsuite/ChangeLog: 

2002-10-29  Adam Nemet  <anemet@lnxw.com>

	* gcc.c-torture/execute/941014-1.x: thumb-elf was deprecated, use
	-mthumb.  Only xfail with -O0.

Index: 941014-1.x
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/testsuite/gcc.c-torture/execute/941014-1.x,v
retrieving revision 1.2
diff -c -r1.2 941014-1.x
*** 941014-1.x	16 Dec 1998 22:13:15 -0000	1.2
--- 941014-1.x	31 Oct 2002 08:42:57 -0000
***************
*** 1,6 ****
! # This doesn't work for thumb-elf
   
! if { [istarget "thumb-*-elf"] } {
!         set torture_execute_xfail "thumb-*-elf"
  }
  return 0
--- 1,16 ----
! # This doesn't always work for Thumb.
   
! if { [istarget arm*-*-*] || [istarget xscale*-*-*] \
!      || [istarget strongarm*-*-*] } {
!     set torture_eval_before_execute {
! 	global compiler_conditional_xfail_data
! 	set compiler_conditional_xfail_data {
! 	    "Thumb sets the last bit of function relocations" \
! 		    { "arm*-*-*" "xscale*-*-*" "strongarm*-*-*" } \
! 		    { { "-mthumb" "-O0" } } \
! 		    { "" }
! 	}
!     }
  }
+ 
  return 0

Re: [PATCH, arm] Fix XFAIL in gcc.c-torture/execute/941014-1.x

[Richard Earnshaw]

> 2002-10-29  Adam Nemet  <anemet@lnxw.com>
> 
> 	* gcc.c-torture/execute/941014-1.x: thumb-elf was deprecated, use
> 	-mthumb.  Only xfail with -O0.

OK
R.

Re: [PATCH, arm] Fix XFAIL in gcc.c-torture/execute/941014-1.x

[Adam Nemet]

I have no write access to CVS, can you also apply the patch please.
Thanks, Adam

Richard Earnshaw <rearnsha@arm.com> writes:

> > 2002-10-29  Adam Nemet  <anemet@lnxw.com>
> > 
> > 	* gcc.c-torture/execute/941014-1.x: thumb-elf was deprecated, use
> > 	-mthumb.  Only xfail with -O0.
> 
> OK
> R.

Re: [PATCH, arm] Fix XFAIL in gcc.c-torture/execute/941014-1.x

[Adam Nemet]

> > 2002-10-29  Adam Nemet  <anemet@lnxw.com>
> > 
> > 	* gcc.c-torture/execute/941014-1.x: thumb-elf was deprecated, use
> > 	-mthumb.  Only xfail with -O0.
> 
> OK

This testsuite bug is also present on the branch (thumb*-*-* was
already deprecated in 3.2).  Is this OK to the branch?

Adam

Re: [PATCH, arm] Fix XFAIL in gcc.c-torture/execute/941014-1.x

[Richard Earnshaw]

> > > 2002-10-29  Adam Nemet  <anemet@lnxw.com>
> > > 
> > > 	* gcc.c-torture/execute/941014-1.x: thumb-elf was deprecated, use
> > > 	-mthumb.  Only xfail with -O0.
> > 
> > OK
> 
> This testsuite bug is also present on the branch (thumb*-*-* was
> already deprecated in 3.2).  Is this OK to the branch?

No, generally we don't change things of that nature at this point of such 
a branch.

R.