* Patch: gcc/unwind-dw2{-fde,}.c: Warning removal.
@ 2002-11-06 0:51 rbrown64
2002-11-06 6:37 ` Kaveh R. Ghazi
0 siblings, 1 reply; 2+ messages in thread
From: rbrown64 @ 2002-11-06 0:51 UTC (permalink / raw)
To: gcc-patches
Remove the following warnings from the 1104 snapshot on
powerpc-apple-darwin6.0 .
1104/gcc/unwind-dw2.c: In function `extract_cie_info':
1104/gcc/unwind-dw2.c:228: warning: implicit declaration of function `strlen'
1104/gcc/unwind-dw2.c: In function `uw_frame_state_for':
1104/gcc/unwind-dw2.c:906: warning: implicit declaration of function `memset'
1104/gcc/unwind-dw2.c: In function `uw_install_context_1':
1104/gcc/unwind-dw2.c:1193: warning: implicit declaration of function `memcpy'
1104/gcc/unwind-dw2-fde.c: In function `get_cie_encoding':
1104/gcc/unwind-dw2-fde.c:271: warning: implicit declaration of function `strlen
'
Past the compare in the bootstrap.
2002-11-06 Rodney Brown <rbrown64@csc.com.au>
* unwind-dw2-fde.c: Include string.h.
* unwind-dw2.c: Include string.h.
--- unwind-dw2-fde.c.orig Sat Jun 1 08:15:39 2002
+++ unwind-dw2-fde.c Wed Nov 6 17:54:15 2002
@@ -37,6 +37,9 @@ Software Foundation, 59 Temple Place - S
#include "unwind-pe.h"
#include "unwind-dw2-fde.h"
#include "gthr.h"
+#ifndef inhibit_libc
+#include <string.h>
+#endif
#endif
/* The unseen_objects list contains objects that have been registered
--- unwind-dw2.c.orig Wed Nov 6 17:55:25 2002
+++ unwind-dw2.c Wed Nov 6 17:54:55 2002
@@ -26,6 +26,9 @@
#include "unwind-pe.h"
#include "unwind-dw2-fde.h"
#include "gthr.h"
+#ifndef inhibit_libc
+#include <string.h>
+#endif
#ifndef __USING_SJLJ_EXCEPTIONS__
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Patch: gcc/unwind-dw2{-fde,}.c: Warning removal.
2002-11-06 0:51 Patch: gcc/unwind-dw2{-fde,}.c: Warning removal rbrown64
@ 2002-11-06 6:37 ` Kaveh R. Ghazi
0 siblings, 0 replies; 2+ messages in thread
From: Kaveh R. Ghazi @ 2002-11-06 6:37 UTC (permalink / raw)
To: rbrown64; +Cc: gcc-patches
> 2002-11-06 Rodney Brown <rbrown64@csc.com.au>
>
> * unwind-dw2-fde.c: Include string.h.
> * unwind-dw2.c: Include string.h.
>
> --- unwind-dw2-fde.c.orig Sat Jun 1 08:15:39 2002
> +++ unwind-dw2-fde.c Wed Nov 6 17:54:15 2002
> @@ -37,6 +37,9 @@ Software Foundation, 59 Temple Place - S
> #include "unwind-pe.h"
> #include "unwind-dw2-fde.h"
> #include "gthr.h"
> +#ifndef inhibit_libc
> +#include <string.h>
> +#endif
> #endif
I believe this is the wrong approach. Instead try setting
xm_defines=POSIX in the x86 & ppc darwin entries in config.gcc.
(That's how every other port fixes this issue.)
This will trigger an include of string.h in tsystem.h. All target
files (should) include tsystem.h. I checked and unwind-dw2*.c do, so
it should work.
Thanks,
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-11-06 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-06 0:51 Patch: gcc/unwind-dw2{-fde,}.c: Warning removal rbrown64
2002-11-06 6:37 ` Kaveh R. Ghazi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).