From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21433 invoked by alias); 18 Nov 2002 19:44:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21422 invoked from network); 18 Nov 2002 19:44:40 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 18 Nov 2002 19:44:40 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gAIJL0w21293 for ; Mon, 18 Nov 2002 14:21:00 -0500 Received: from post-office.corp.redhat.com (post-office.corp.redhat.com [172.16.52.227]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gAIJidD11108; Mon, 18 Nov 2002 14:44:39 -0500 Received: from greed.delorie.com (dj.cipe.redhat.com [10.0.0.222]) by post-office.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gAIJidl17838; Mon, 18 Nov 2002 14:44:39 -0500 Received: (from dj@localhost) by greed.delorie.com (8.11.6/8.11.6) id gAIJicS04560; Mon, 18 Nov 2002 14:44:38 -0500 Date: Mon, 18 Nov 2002 11:44:00 -0000 Message-Id: <200211181944.gAIJicS04560@greed.delorie.com> From: DJ Delorie To: drow@mvista.com CC: gcc-patches@sources.redhat.com In-reply-to: <20021118174038.GA12204@nevyn.them.org> (message from Daniel Jacobowitz on Mon, 18 Nov 2002 12:40:38 -0500) Subject: Re: Add make_relative_prefix to libiberty References: <20021118174038.GA12204@nevyn.them.org> X-SW-Source: 2002-11/txt/msg01044.txt.bz2 > 2002-11-18 Daniel Jacobowitz > > * libiberty.h (make_relative_prefix): Add prototype. > > 2002-11-18 Daniel Jacobowitz > > * Makefile.in: Add make-relative-prefix.c. > * make-relative-prefix.c: New file. You're creating an obstack which will become impossible to clean up after. Please just call malloc (not xmalloc). Return NULL on allocation failure. Please note the allocation rules in the header. Please regenerate the documentation from the source. Please check for valid (i.e. non-NULL arguments). The comment "Determine if the compiler is installed in the standard location" would no longer be appropriate. You may not call xmalloc or friends from any of these functions, you must instead signal an allocation error to the application somehow. You have also changed the copyright terms (GPL -> LGPL). Do you have the FSF's permission to do so? > 2002-11-18 Daniel Jacobowitz > > * gcc.c (make_relative_prefix): Remove. > (free_split_directores, split_directories): Remove. I can't approve the gcc changes, of course.