From: Richard Henderson <rth@redhat.com>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [RFA:] Take 2 (was: Re: RFC: --enable-checking=valgrind.)
Date: Mon, 18 Nov 2002 20:37:00 -0000 [thread overview]
Message-ID: <20021118203717.A3046@redhat.com> (raw)
In-Reply-To: <Pine.BSF.4.44.0211182022110.61397-100000@dair.pair.com>; from hp@bitrange.com on Mon, Nov 18, 2002 at 09:24:19PM -0500
On Mon, Nov 18, 2002 at 09:24:19PM -0500, Hans-Peter Nilsson wrote:
> * Makefile.in (RUN_GEN, VALGRIND_DRIVER_DEFINES): New variables.
> (DRIVER_DEFINES): Add $(VALGRIND_DRIVER_DEFINES).
> (executing gencheck, genconfigs, genconditions, genflags,
> gencodes, genconstants, genemit, genrecog, genopinit, genextract,
> genpeep, genattr, genattrtab, genoutput, gengenrtl, genpreds,
> gengtype, genprotos): Prepend $(RUN_GEN).
> * configure.in: Move host compiler tests before --enable-checking
> tests.
> (--enable-checking=valgrind): New.
> * config.in, configure: Regenerate.
> * cppfiles.c (read_include_file) [ENABLE_VALGRIND_CHECKING]: When
> doing the mmap+1 trick, annotate the byte after the mmap:ed area
> as readable.
> (purge_cache) [ENABLE_VALGRIND_CHECKING]: Remove above annotation.
> * gcc.c (execute) [ENABLE_VALGRIND_CHECKING]: Arrange to prepend
> VALGRIND_PATH -q to each command.
Updated patch is ok.
Really, I don't think you needed to have combined the cpp fix with the
base valgrind invocation patch.
r~
next prev parent reply other threads:[~2002-11-19 4:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-10 17:35 RFC: --enable-checking=valgrind Hans-Peter Nilsson
2002-11-10 19:34 ` Zack Weinberg
2002-11-11 1:55 ` Hans-Peter Nilsson
2002-11-11 16:53 ` Zack Weinberg
2002-11-11 17:48 ` Hans-Peter Nilsson
2002-11-12 6:02 ` Jan Hubicka
2002-11-12 17:11 ` Hans-Peter Nilsson
2002-11-12 17:21 ` Zack Weinberg
2002-11-13 5:32 ` Jan Hubicka
2002-11-13 13:38 ` Hans-Peter Nilsson
2002-11-18 17:20 ` Richard Henderson
2002-11-18 18:24 ` [RFA:] Take 2 (was: Re: RFC: --enable-checking=valgrind.) Hans-Peter Nilsson
2002-11-18 20:37 ` Richard Henderson [this message]
2002-11-20 11:57 ` Hans-Peter Nilsson
2002-11-18 22:12 ` Neil Booth
2002-11-19 4:37 ` Hans-Peter Nilsson
2002-11-18 22:33 ` Andreas Jaeger
2002-11-19 4:33 ` Hans-Peter Nilsson
2002-11-19 7:31 ` Andreas Jaeger
2002-11-19 9:07 ` Hans-Peter Nilsson
2002-11-19 9:15 ` [RFA:] Take 2 Andreas Jaeger
2002-11-26 5:42 ` [PATCH] Fix configure (was Re: [RFA:] Take 2 (was: Re: RFC: --enable-checking=valgrind.)) Jakub Jelinek
2002-11-26 9:59 ` Richard Henderson
2002-11-28 7:34 ` Hans-Peter Nilsson
2002-11-28 8:08 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021118203717.A3046@redhat.com \
--to=rth@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).