From: Richard Henderson <rth@redhat.com>
To: Casper Hornstrup <chorns@users.sourceforge.net>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fastcall support on cygwin and mingw targets
Date: Mon, 25 Nov 2002 15:39:00 -0000 [thread overview]
Message-ID: <20021125233927.GO25134@redhat.com> (raw)
In-Reply-To: <001e01c28bfa$db5b16e0$0300000a@csiteoffice.csite.com>
First, please avoid putting the patch into a tarball. It just
makes it harder to review.
On Thu, Nov 14, 2002 at 05:28:25PM +0100, Casper Hornstrup wrote:
> ! /* Output a reference to a label. Fastcall symbols are prefixed with @,
> ! whereas symbols for functions using other calling conventions don't
> ! have a prefix (unless they are marked dllimport or dllexport).
> ! Internally, @ is used as a prefix for symbols that are marked dllimport
> ! or dllexport so internally the prefix + is used for fastcall symbols. */
> #undef ASM_OUTPUT_LABELREF
> ! #define ASM_OUTPUT_LABELREF(STREAM, NAME) \
(1) This is now so big it should be moved to an external function.
(2) The frobbing of @ and + is confusing. It is not *required*
that @ be used for dllimport/export. I'd prefer to first see
a patch that replaced the literal @ with a macro; then the macro
can expand to something other than @, and your life is happier.
> + The @code{fastcall} calling convention exists in Windows for Intel
> + processors only.
This is false. It exists on all ia32 targets. The name mangling
only happens on Windows, but that is not required for the calling
convention to be in effect.
r~
next prev parent reply other threads:[~2002-11-25 23:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-30 21:14 PATCH: Re: optimization/6162: gcc 3.0.4: certain i386 asm reloader ice Nathanael Nerode
2002-11-10 8:17 ` [PATCH] Fastcall support on cygwin and mingw targets Casper Hornstrup
2002-11-10 17:50 ` Fergus Henderson
2002-11-10 19:10 ` Christopher Faylor
2002-11-11 12:47 ` Casper Hornstrup
2002-11-11 12:27 ` Fergus Henderson
2002-11-12 10:45 ` Casper Hornstrup
2002-11-12 22:08 ` Fergus Henderson
2002-11-13 12:17 ` Casper Hornstrup
2002-11-13 15:47 ` Joseph S. Myers
2002-11-13 20:27 ` Fergus Henderson
2002-11-14 0:31 ` Joseph S. Myers
2002-11-14 8:28 ` Casper Hornstrup
2002-11-25 15:39 ` Richard Henderson [this message]
2002-11-27 19:52 ` Casper Hornstrup
2002-11-27 21:15 ` Casper Hornstrup
2002-11-27 22:19 ` Richard Henderson
2002-11-28 2:00 ` Richard Henderson
2002-12-02 13:25 ` Casper Hornstrup
2002-12-02 13:48 ` Richard Henderson
2002-12-03 13:52 ` Casper Hornstrup
2002-12-03 16:32 ` Richard Henderson
2002-12-08 4:08 ` Casper Hornstrup
2002-12-19 14:01 ` Richard Henderson
2002-12-19 14:07 ` Casper Hornstrup
2002-11-20 11:03 Casper Hornstrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021125233927.GO25134@redhat.com \
--to=rth@redhat.com \
--cc=chorns@users.sourceforge.net \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).