fix all-gcc target in toplevel Makefile.in

fix all-gcc target in toplevel Makefile.in

[Geoffrey Keating]

I changed a file in the GCC sources in my powerpc-eabisim cross,
deleted the target libraries, typed 'make' at the toplevel, and
watched the commands fly by.  About 20 seconds later, something at the
back of my mind started trying to get my attention, and I checked the
build logs.  I saw that in fact nothing in GCC got rebuilt.  It's a
good thing I noticed that, or I'd have committed a completely untested
patch. This completely bogus chunk of code was responsible; it's a
workaround for a problem that is much worse than the original problem.

Tested on powerpc-eabisim.

-- 
- Geoffrey Keating <geoffk@apple.com>

===File ~/patches/config-makegcc.patch======================
2002-12-16  Geoffrey Keating  <geoffk@apple.com>

	* Makefile.in (all-gcc): Let GCC makefile determine if
	GCC needs to be rebuilt.

Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/Makefile.in,v
retrieving revision 1.130
diff -u -p -u -p -r1.130 Makefile.in
--- Makefile.in	16 Dec 2002 18:18:41 -0000	1.130
+++ Makefile.in	17 Dec 2002 05:05:53 -0000
@@ -7460,20 +7460,13 @@ gcc/Makefile: config.status
 	  $(HOST_CONFIGARGS) $${srcdiroption} \
 	  || exit 1
 
-# Don't remake gcc if it's already been made by 'bootstrap'; that causes
-# nothing but trouble.  This wart will be fixed eventually by moving
-# the bootstrap behavior to this file.
 .PHONY: all-gcc maybe-all-gcc
 maybe-all-gcc:
 all-gcc: configure-gcc
-	@if [ -f gcc/xgcc ] ; then \
-	  exit 0 ; \
-	else \
-	  r=`${PWD}`; export r; \
-	  s=`cd $(srcdir); ${PWD}`; export s; \
-	  $(SET_LIB_PATH) \
-	  (cd gcc; $(MAKE) $(GCC_FLAGS_TO_PASS) all); \
-	fi
+	r=`${PWD}`; export r; \
+	s=`cd $(srcdir); ${PWD}`; export s; \
+	$(SET_LIB_PATH) \
+	(cd gcc; $(MAKE) $(GCC_FLAGS_TO_PASS) all); \
 
 # Building GCC uses some tools for rebuilding "source" files
 # like texinfo, bison/byacc, etc.  So we must depend on those.
============================================================

Re: fix all-gcc target in toplevel Makefile.in

[DJ Delorie]

> 2002-12-16  Geoffrey Keating  <geoffk@apple.com>
> 
> 	* Makefile.in (all-gcc): Let GCC makefile determine if
> 	GCC needs to be rebuilt.

This adds back the problem we were trying to avoid.  Jason's patch is
a more appropriate fix.