* Re: [patch] function.c: clear MEM flags better
@ 2003-03-06 0:36 Richard Kenner
2003-03-06 1:28 ` DJ Delorie
0 siblings, 1 reply; 3+ messages in thread
From: Richard Kenner @ 2003-03-06 0:36 UTC (permalink / raw)
To: dj; +Cc: gcc-patches
+ if (MEM_ATTRS (p->slot))
+ MEM_ATTRS (p->slot)->alias = 0;
I don't like this. For one thing, nobody outside emit-rtl.c should know the
format of a MEM_ATTRS, but the major problem is there's absolutely no
documentation here saying what's going on and why.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] function.c: clear MEM flags better
2003-03-06 0:36 [patch] function.c: clear MEM flags better Richard Kenner
@ 2003-03-06 1:28 ` DJ Delorie
0 siblings, 0 replies; 3+ messages in thread
From: DJ Delorie @ 2003-03-06 1:28 UTC (permalink / raw)
To: kenner; +Cc: gcc-patches
> + if (MEM_ATTRS (p->slot))
> + MEM_ATTRS (p->slot)->alias = 0;
>
> I don't like this. For one thing, nobody outside emit-rtl.c should know the
> format of a MEM_ATTRS, but the major problem is there's absolutely no
> documentation here saying what's going on and why.
I looked up the original problem report for this patch, and the test
case no longer causes a compiler crash. Patch withdrawn (for now at
least ;).
The original crash was thusly:
t20.c:17: Internal compiler error in set_mem_alias_set, at emit-rtl.c:1751
/* If the new and old alias sets don't conflict, something is wrong. */
if (!alias_sets_conflict_p (set, MEM_ALIAS_SET (mem)))
abort ();
^ permalink raw reply [flat|nested] 3+ messages in thread
* [patch] function.c: clear MEM flags better
@ 2003-03-06 0:24 DJ Delorie
0 siblings, 0 replies; 3+ messages in thread
From: DJ Delorie @ 2003-03-06 0:24 UTC (permalink / raw)
To: gcc-patches
Another one from our internal branch...
2002-03-05 Chris Moller <cmoller@redhat.com>
* function.c (assign_stack_temp_for_type): set
MEM_ATTRS (p->slot)->alias to zero as part of clearing
MEM flags before set_mem_alias_set().
Index: function.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/function.c,v
retrieving revision 1.405
diff -p -2 -r1.405 function.c
*** function.c 4 Mar 2003 06:20:12 -0000 1.405
--- function.c 6 Mar 2003 00:20:02 -0000
*************** assign_stack_temp_for_type (mode, size,
*** 807,810 ****
--- 807,812 ----
}
+ if (MEM_ATTRS (p->slot))
+ MEM_ATTRS (p->slot)->alias = 0;
/* Create a new MEM rtx to avoid clobbering MEM flags of old slots. */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-03-06 1:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-06 0:36 [patch] function.c: clear MEM flags better Richard Kenner
2003-03-06 1:28 ` DJ Delorie
-- strict thread matches above, loose matches on Subject: below --
2003-03-06 0:24 DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).