From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4219 invoked by alias); 6 Mar 2003 23:13:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4211 invoked from network); 6 Mar 2003 23:13:59 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 6 Mar 2003 23:13:59 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18r6S1-0006dr-00; Thu, 06 Mar 2003 19:15:05 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18r4Yg-0002Z5-00; Thu, 06 Mar 2003 18:13:50 -0500 Date: Thu, 06 Mar 2003 23:13:00 -0000 From: Daniel Jacobowitz To: Nathanael Nerode Cc: gcc-patches@gcc.gnu.org Subject: Re: [patch] config.gcc untabification Message-ID: <20030306231350.GA9784@nevyn.them.org> Mail-Followup-To: Nathanael Nerode , gcc-patches@gcc.gnu.org References: <20030306230951.GA14847@doctormoo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030306230951.GA14847@doctormoo> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-03/txt/msg00571.txt.bz2 On Thu, Mar 06, 2003 at 06:09:51PM -0500, Nathanael Nerode wrote: > > >I still strongly oppose this sort of patch. You're reindenting a file > >that isn't violating a well-defined indentation standard. You're > >touching just about all of the file to do it. Skimming the file, most > >of the 80-column-violations wouldn't be affected by this anyway, so I > >don't find that convincing. And I didn't see any blatant deviations > >from its tab-based indentation style either. > > You weren't looking hard enough. There are lots. Then just fix them instead of thrashing the file. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer