From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15527 invoked by alias); 19 Oct 2003 18:31:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15520 invoked from network); 19 Oct 2003 18:31:39 -0000 Received: from unknown (HELO atrey.karlin.mff.cuni.cz) (195.113.31.123) by sources.redhat.com with SMTP; 19 Oct 2003 18:31:39 -0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4018) id 0D9B24C0442; Sun, 19 Oct 2003 20:31:39 +0200 (CEST) Date: Sun, 19 Oct 2003 18:38:00 -0000 From: Jan Hubicka To: Zack Weinberg Cc: Zdenek Dvorak , gcc-patches@gcc.gnu.org Subject: Re: Patch ping Message-ID: <20031019183138.GX15904@atrey.karlin.mff.cuni.cz> References: <20031019101617.GA15107@atrey.karlin.mff.cuni.cz> <874qy5ruw7.fsf@egil.codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874qy5ruw7.fsf@egil.codesourcery.com> User-Agent: Mutt/1.3.28i X-SW-Source: 2003-10/txt/msg01641.txt.bz2 > Zdenek Dvorak writes: > > > Hello, > > > > could someone please review > > > > http://gcc.gnu.org/ml/gcc-patches/2003-07/msg02991.html? > > > > I would like to get this in, since it uses value profiling, and I feel > > wrong about having a piece of unused and therefore untested code in gcc. > > And of course, it also makes a nice improvement in benchmarks. > > I don't see anything wrong with the code, but I would like someone > more familiar with the profiler to comment. Since this was submitted > well before the deadline and only affects a non-default optimization > mode, I think it can go in now if (say) Nathan Sidwell thinks the code > is sound. The actual interface to profiling code came in earlier with separate patch. This patch has no consequences to the profiling, just uses the interface we agreed on earlier, so I would say that there is no problem from profiler side. (this is also why I don't feel this belong to area I can approve as gcov maintainer) Honza > > You have some English grammar issues with the documentation. > > zw