From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21366 invoked by alias); 9 Mar 2004 05:05:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21359 invoked from network); 9 Mar 2004 05:05:32 -0000 Received: from unknown (HELO bubble.modra.org) (144.136.178.58) by sources.redhat.com with SMTP; 9 Mar 2004 05:05:32 -0000 Received: by bubble.modra.org (Postfix, from userid 500) id 69838CEEB0; Tue, 9 Mar 2004 15:35:31 +1030 (CST) Date: Fri, 19 Mar 2004 08:14:00 -0000 From: Alan Modra To: Richard Henderson , gcc-patches@gcc.gnu.org Subject: Re: Powerpc64 long double support Message-ID: <20040309050531.GG28377@bubble.modra.org> Mail-Followup-To: Richard Henderson , gcc-patches@gcc.gnu.org References: <40491948.2010900@us.ibm.com> <20040306105033.GF2715@bubble.modra.org> <200403062313.i26NDipA015313@desire.geoffk.org> <20040307063708.GD18129@bubble.modra.org> <20040307073023.GA13420@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040307073023.GA13420@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2004-03/txt/msg00743.txt.bz2 Message-ID: <20040319081400.5AX9kGk_hV6xxH22rrWoecnrqyndayylC6PjGBhBHo0@z> On Sat, Mar 06, 2004 at 11:30:23PM -0800, Richard Henderson wrote: > On Sun, Mar 07, 2004 at 05:07:08PM +1030, Alan Modra wrote: > > - operands[2] = CONST0_RTX (DFmode); > > + REAL_VALUE_TYPE rv; > > + /* Make a -0.0 */ > > + memset (&rv, 0, sizeof (rv)); > > + rv.sign = 1; > > + operands[2] = CONST_DOUBLE_FROM_REAL_VALUE (rv, DFmode); > > How about > > REAL_VALUE_TYPE rv = REAL_VALUE_NEGATE (dconst0); Well, it's nicer to hide the details of REAL_VALUE_TYPE, but.. REAL_VALUE_NEGATE needs NEGATE_EXPR. ie. you need to arrange for tree.h to be included in insn-emit.c. An easy patch to genemit.c, but is it a good idea? Also, real_arithmetic2 is slower than memset. Hmm, I suppose I could roll my own dconstm0 or even dfmode_m0_rtx. Doesn't seem worth it though. -- Alan Modra IBM OzLabs - Linux Technology Centre