From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4749 invoked by alias); 19 Apr 2004 12:10:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 4742 invoked from network); 19 Apr 2004 12:10:42 -0000 Received: from unknown (HELO dublin.act-europe.fr) (212.157.227.154) by sources.redhat.com with SMTP; 19 Apr 2004 12:10:42 -0000 Received: by dublin.act-europe.fr (Postfix, from userid 525) id 225F522BA1C; Mon, 19 Apr 2004 14:10:42 +0200 (MET DST) Date: Mon, 19 Apr 2004 12:10:00 -0000 From: Arnaud Charlet To: Paolo Bonzini Cc: Arnaud Charlet , Andreas Jaeger , gcc-patches@gcc.gnu.org Subject: Re: Patch ping Message-ID: <20040419141041.A21356@dublin.act-europe.fr> References: <20040419115614.A20023@dublin.act-europe.fr> <00c101c425f5$62144f90$8741af83@paride> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <00c101c425f5$62144f90$8741af83@paride>; from paolo.bonzini@polimi.it on Mon, Apr 19, 2004 at 12:02:10PM +0200 X-SW-Source: 2004-04/txt/msg01148.txt.bz2 > Dense MS Outlook Express. :-( You first patch causes cpu usage problem as mentioned by Laurent, so that's probably not reasonable. In addition, maintaining a baseline of all failures on all these levels of switches will also be very painful. -O0 was clearly the simplest (in particular on platforms where optimizations are somewhat fragile), and has the advantage of being clean on a few platforms, making it easier to perform comparisons. -O2 is a good compromise, since as shown recently, it is often the case that middle-end or optimization bugs only show up in the context of Ada code, although not specifically Ada related. As for your second patch, that's really a temporary work around, since the bugs shown are most likely general bugs not Ada specific, and that will likely appear in complex C/C++ code as well. As such, it should really be marked with comments explaining why the code is there, and that it's temporary. A bugzilla PR should also be opened to remind us that you've put in place this temporary work around. Arno