From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1769 invoked by alias); 25 Apr 2004 16:37:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1728 invoked from network); 25 Apr 2004 16:37:28 -0000 Received: from unknown (HELO atrey.karlin.mff.cuni.cz) (195.113.31.123) by sources.redhat.com with SMTP; 25 Apr 2004 16:37:28 -0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 29025) id 371A94C0347; Sun, 25 Apr 2004 18:37:28 +0200 (CEST) Date: Sun, 25 Apr 2004 16:37:00 -0000 From: Zdenek Dvorak To: Aldy Hernandez Cc: Nathan Sidwell , gcc-patches@gcc.gnu.org Subject: Re: Patch ping Message-ID: <20040425163728.GA5092@atrey.karlin.mff.cuni.cz> References: <20040423110837.GB12376@atrey.karlin.mff.cuni.cz> <40891B4F.5070908@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.4i X-SW-Source: 2004-04/txt/msg01683.txt.bz2 Hello, > >> http://gcc.gnu.org/ml/gcc-patches/2004-03/msg01148.html > >> -- the patch to prevent code with -fprofile-arcs and > >> -fbranch-probabilities from diverging before the > >> profile feedback pass (which may cause profile missmatches) > > this one is ok, wrt the libgcov bits > > Hi Nathan. Hi Zdenek. > > The gcov changes broke powerpc-eabi*, and possibly all embedded > targets. See below. "pid_t" is not declared where you think it is. > > Aldy > > In file included from > /home/cygnus/aldyh/source/untainted-sources/uber/gcc/libgcov.c:51: > /home/cygnus/aldyh/source/untainted-sources/uber/gcc/gcov-io.h:452: > error: parse error before "__gcov_fork" > /home/cygnus/aldyh/source/untainted-sources/uber/gcc/gcov-io.h:452: > warning: type defaults to nt' in declaration of _gcov_fork' > /home/cygnus/aldyh/source/untainted-sources/uber/gcc/gcov-io.h:452: > warning: data definition has no type or storage class > make[1]: *** [libgcc/./_gcov.o] Error 1 this patch fixes the problem, by not declaring the functions when inhibit_libc is defined. Commited as obvious. Zdenek * gcov-io.h (__gcov_fork, __gcov_execl, __gcov_execlp, * __gcov_execle, __gcov_execv, __gcov_execvp, __gcov_execve): Do not declare when inhibit_libc is defined. Index: gcov-io.h =================================================================== RCS file: /cvs/gcc/gcc/gcc/gcov-io.h,v retrieving revision 1.49 diff -c -3 -p -r1.49 gcov-io.h *** gcov-io.h 23 Apr 2004 22:50:16 -0000 1.49 --- gcov-io.h 25 Apr 2004 16:33:30 -0000 *************** extern void __gcov_merge_single (gcov_ty *** 448,453 **** --- 448,454 ---- consecutive values. */ extern void __gcov_merge_delta (gcov_type *, unsigned); + #ifndef inhibit_libc /* The wrappers around some library functions.. */ extern pid_t __gcov_fork (void); extern int __gcov_execl (const char *, const char *, ...); *************** extern int __gcov_execle (const char *, *** 456,461 **** --- 457,463 ---- extern int __gcov_execv (const char *, char *const []); extern int __gcov_execvp (const char *, char *const []); extern int __gcov_execve (const char *, char *const [], char *const []); + #endif #endif /* IN_LIBGCOV */