From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9657 invoked by alias); 28 Apr 2004 13:56:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9642 invoked from network); 28 Apr 2004 13:56:15 -0000 Received: from unknown (HELO colossus.systems.pipex.net) (62.241.160.73) by sources.redhat.com with SMTP; 28 Apr 2004 13:56:15 -0000 Received: from nowt.org (81-178-210-210.dsl.pipex.com [81.178.210.210]) by colossus.systems.pipex.net (Postfix) with ESMTP id AA33F1C00170; Wed, 28 Apr 2004 14:56:14 +0100 (BST) Received: from wren.home (wren.home [192.168.1.7]) by nowt.org (Postfix) with ESMTP id 20469AC92; Wed, 28 Apr 2004 14:56:14 +0100 (BST) From: Paul Brook Organization: CodeSourcery To: Richard Earnshaw Subject: Re: Patch ping Date: Wed, 28 Apr 2004 14:02:00 -0000 User-Agent: KMail/1.6.2 Cc: gcc-patches@gcc.gnu.org References: <200404281433.58671.paul@codesourcery.com> <1083160020.14083.112.camel@pc960.cambridge.arm.com> In-Reply-To: <1083160020.14083.112.camel@pc960.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200404281456.12877.paul@codesourcery.com> X-SW-Source: 2004-04/txt/msg01866.txt.bz2 On Wednesday 28 April 2004 14:47, Richard Earnshaw wrote: > On Wed, 2004-04-28 at 14:33, Paul Brook wrote: > > Patch ping: Output dwarf expressions for memory locations involving > > shifts. > > > > http://gcc.gnu.org/ml/gcc-patches/2004-04/msg00856.html > > > > Paul > > I don't think this is quite right. The MULT code had some > simplifications when one of the operands was 0. However, a shift by > zero is not the same as a multiply by zero -- the later results in zero, > the former is a NOP. Are you sure? I see a check for (op0==0 || op1=0), but this is testing for successful evaluation, not actual values. Paul