[patch] testsuite fix for math tests on darwin

[patch] testsuite fix for math tests on darwin

[Andreas Tobler]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi,

darwin has some C99 math functions in the libmx instead of libm, so we 
should add the -lmx to the tests where we need these functions.
The attached patch fixes three failures of the libstdc++ suite.
Unfortunately I did not find the cabsl in libmx.

Ok for main?

Andreas

2004-06-06  Andreas Tobler  <a.tobler@schweiz.ch>

	* testsuite/26_numerics/c_math_dynamic.cc: Add -lmx for C99 functions
	on target darwin.
	* testsuite/26_numerics/complex_value.cc: Likewise.
	* testsuite/26_numerics/complex/pow.cc: Likewise.


[-- Attachment #2: darwin-c99.diff --]
[-- Type: text/plain, Size: 1744 bytes --]

Index: testsuite/26_numerics/c_math_dynamic.cc
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/testsuite/26_numerics/c_math_dynamic.cc,v
retrieving revision 1.2
diff -u -r1.2 c_math_dynamic.cc
--- testsuite/26_numerics/c_math_dynamic.cc	23 Sep 2003 20:02:52 -0000	1.2
+++ testsuite/26_numerics/c_math_dynamic.cc	6 Jun 2004 13:15:18 -0000
@@ -29,6 +29,7 @@
 
 // { dg-do link }
 // { dg-options "-D_XOPEN_SOURCE" { target *-*-freebsd* } }
+// { dg-options "-lmx" { target powerpc-apple-darwin7* } }
 
 #include <cmath>
 
Index: testsuite/26_numerics/complex_value.cc
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/testsuite/26_numerics/complex_value.cc,v
retrieving revision 1.6
diff -u -r1.6 complex_value.cc
--- testsuite/26_numerics/complex_value.cc	4 Mar 2004 23:29:41 -0000	1.6
+++ testsuite/26_numerics/complex_value.cc	6 Jun 2004 13:15:18 -0000
@@ -20,6 +20,8 @@
 // Software Foundation, 59 Temple Place - Suite 330, Boston, MA 02111-1307,
 // USA.
 
+// { dg-options "-lmx" { target powerpc-apple-darwin7* } }
+
 #include <complex>
 #include <testsuite_hooks.h>
 
Index: testsuite/26_numerics/complex/pow.cc
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/testsuite/26_numerics/complex/pow.cc,v
retrieving revision 1.1
diff -u -r1.1 pow.cc
--- testsuite/26_numerics/complex/pow.cc	10 Mar 2004 09:16:12 -0000	1.1
+++ testsuite/26_numerics/complex/pow.cc	6 Jun 2004 13:15:18 -0000
@@ -1,5 +1,6 @@
 // PR libbstdc++/10689
 // Origin: Daniel.Levine@jhuaph.edu
+// { dg-options "-lmx" { target powerpc-apple-darwin7* } }
 
 #include <complex>
 #include <testsuite_hooks.h>

Re: [patch] testsuite fix for math tests on darwin

[Gabriel Dos Reis]

Andreas Tobler <toa@pop.agri.ch> writes:

| Hi,
| 
| darwin has some C99 math functions in the libmx instead of libm, so we
| should add the -lmx to the tests where we need these functions.
| The attached patch fixes three failures of the libstdc++ suite.
| Unfortunately I did not find the cabsl in libmx.
| 
| Ok for main?

Shouldn't the compiler driver take care of that?  Those functions are
used by libstdc++, so when linking againt libstdc++, the driver should
be passing that additional library too, instead of us setting them in the
testsuite. 

-- Gaby

Re: [patch] testsuite fix for math tests on darwin

[Dale Johannesen]

On Jun 6, 2004, at 6:27 AM, Andreas Tobler wrote:
> darwin has some C99 math functions in the libmx instead of libm, so we 
> should add the -lmx to the tests where we need these functions.
> The attached patch fixes three failures of the libstdc++ suite.
> Unfortunately I did not find the cabsl in libmx.

There's been some discussion of this issue at Apple.  I think we're 
leaning in the direction
of having the driver include -lmx automagically.  In fact I thought 
Andrew already had a
patch in that did this for C++.   Comments?
(An obvious question is, Why are they in libmx?  All I can tell you is 
the compiler people
don't control that...)

Re: [patch] testsuite fix for math tests on darwin

[Gabriel Dos Reis]

Dale Johannesen <dalej@apple.com> writes:

| On Jun 6, 2004, at 6:27 AM, Andreas Tobler wrote:
| > darwin has some C99 math functions in the libmx instead of libm, so
| > we should add the -lmx to the tests where we need these functions.
| > The attached patch fixes three failures of the libstdc++ suite.
| > Unfortunately I did not find the cabsl in libmx.
| 
| There's been some discussion of this issue at Apple.  I think we're
| leaning in the direction
| of having the driver include -lmx automagically.  In fact I thought
| Andrew already had a
| patch in that did this for C++.   Comments?

I think that is the obvious solution, at least as far as V3 is
concerned.  We don't require user to say -lm when they use C++.
I consider it to be a bug that the C driver requires that explicit
setting a bug -- but, hey, that is a different story :-)

| (An obvious question is, Why are they in libmx?

Yes, :-)

| All I can tell you is
| the compiler people
| don't control that...)

-- Gaby

Re: [patch] testsuite fix for math tests on darwin

[Andreas Tobler]

Gabriel Dos Reis wrote:
> Dale Johannesen <dalej@apple.com> writes:
> 
> | On Jun 6, 2004, at 6:27 AM, Andreas Tobler wrote:
> | > darwin has some C99 math functions in the libmx instead of libm, so
> | > we should add the -lmx to the tests where we need these functions.
> | > The attached patch fixes three failures of the libstdc++ suite.
> | > Unfortunately I did not find the cabsl in libmx.
> | 
> | There's been some discussion of this issue at Apple.  I think we're
> | leaning in the direction
> | of having the driver include -lmx automagically.  In fact I thought
> | Andrew already had a
> | patch in that did this for C++.   Comments?
> 
> I think that is the obvious solution, at least as far as V3 is
> concerned.  We don't require user to say -lm when they use C++.
> I consider it to be a bug that the C driver requires that explicit
> setting a bug -- but, hey, that is a different story :-)

Ok, fine with me. But then we should find this patch and make it work.

I just wanted to make them pass, to get a clear picture what is wrong 
and what is just not done correctly.

Andreas

Re: [patch] testsuite fix for math tests on darwin

[Dale Johannesen]

On Jun 6, 2004, at 9:49 AM, Gabriel Dos Reis wrote:

> Dale Johannesen <dalej@apple.com> writes:
>
> | On Jun 6, 2004, at 6:27 AM, Andreas Tobler wrote:
> | > darwin has some C99 math functions in the libmx instead of libm, so
> | > we should add the -lmx to the tests where we need these functions.
> | > The attached patch fixes three failures of the libstdc++ suite.
> | > Unfortunately I did not find the cabsl in libmx.
> |
> | There's been some discussion of this issue at Apple.  I think we're
> | leaning in the direction
> | of having the driver include -lmx automagically.  In fact I thought
> | Andrew already had a
> | patch in that did this for C++.   Comments?
>
> I think that is the obvious solution, at least as far as V3 is
> concerned.  We don't require user to say -lm when they use C++.
> I consider it to be a bug that the C driver requires that explicit
> setting a bug -- but, hey, that is a different story :-)

It doesn't on Darwin, actually, because the C89 math functions are in
the libc-equivalent (libSystem).  This suggests that the C driver
also ought to include -lmx on Darwin.  (Yes, the packaging is strange.)

Re: [patch] testsuite fix for math tests on darwin

[Andrew Pinski]

> 
> Gabriel Dos Reis wrote:
> > Dale Johannesen <dalej@apple.com> writes:
> > 
> > | On Jun 6, 2004, at 6:27 AM, Andreas Tobler wrote:
> > | > darwin has some C99 math functions in the libmx instead of libm, so
> > | > we should add the -lmx to the tests where we need these functions.
> > | > The attached patch fixes three failures of the libstdc++ suite.
> > | > Unfortunately I did not find the cabsl in libmx.
> > | 
> > | There's been some discussion of this issue at Apple.  I think we're
> > | leaning in the direction
> > | of having the driver include -lmx automagically.  In fact I thought
> > | Andrew already had a
> > | patch in that did this for C++.   Comments?
> > 
> > I think that is the obvious solution, at least as far as V3 is
> > concerned.  We don't require user to say -lm when they use C++.
> > I consider it to be a bug that the C driver requires that explicit
> > setting a bug -- but, hey, that is a different story :-)
> 
> Ok, fine with me. But then we should find this patch and make it work.
> 
> I just wanted to make them pass, to get a clear picture what is wrong 
> and what is just not done correctly.

Yes I already did for the C++ driver but I did not know why the testcases
are still failing.  I will look into them when I figure out what is wrong
with my hard drive in my laptop.

Thanks,
Andrew Pinski

Re: [patch] testsuite fix for math tests on darwin

[Benjamin Kosnik]

>Yes I already did for the C++ driver but I did not know why the testcases
>are still failing.  I will look into them when I figure out what is wrong
>with my hard drive in my laptop.

I'm seeing results consistent with:
http://gcc.gnu.org/ml/gcc-testresults/2004-06/msg00097.html

FAIL: 26_numerics/c_math_dynamic.cc (test for excess errors)
Excess errors:
/usr/bin/ld: Undefined symbols:
_acosf

FAIL: 26_numerics/complex/13450.cc (test for excess errors)
Excess errors:
/usr/bin/ld: Undefined symbols:
_cabsf
_cabsl
_carg
_cargf
_cargl
_cexp
_cexpf
_cexpl
_cosf
_expf
_logf
_powf
_sinf
collect2: ld returned 1 exit status


Soooo.... can somebody on the Apple side please take care of this ASAP?

thanks,
benjamin

Re: [patch] testsuite fix for math tests on darwin

[Andrew Pinski]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

> 
> 
> >Yes I already did for the C++ driver but I did not know why the testcases
> >are still failing.  I will look into them when I figure out what is wrong
> >with my hard drive in my laptop.
> 
> I'm seeing results consistent with:
> http://gcc.gnu.org/ml/gcc-testresults/2004-06/msg00097.html
> 

I think everyone at Apple is busy with WWDC related stuff.
I made this patch which should fix it but I have not tested it.  Could
someone test it for me?

Thanks,
Andrew Pinski


[-- Attachment #2: ASCII make commands text, with very long lines --]
[-- Type: text/plain, Size: 23939 bytes --]

? temp.diff.txt
Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/Makefile.in,v
retrieving revision 1.140
diff -u -p -r1.140 Makefile.in
--- Makefile.in	16 Apr 2004 19:04:00 -0000	1.140
+++ Makefile.in	9 Jun 2004 00:07:36 -0000
@@ -1,4 +1,4 @@
-# Makefile.in generated by automake 1.8.2 from Makefile.am.
+# Makefile.in generated by automake 1.8.5 from Makefile.am.
 # @configure_input@
 
 # Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
@@ -45,10 +45,10 @@ DIST_COMMON = README $(am__configure_dep
 	$(top_srcdir)/scripts/check_survey.in \
 	$(top_srcdir)/scripts/testsuite_flags.in ../ABOUT-NLS \
 	../COPYING ../COPYING.LIB ../ChangeLog ../README ../compile \
-	../config.guess ../config.rpath ../config.sub ../install-sh \
-	../ltcf-c.sh ../ltcf-cxx.sh ../ltcf-gcj.sh ../ltconfig \
-	../ltmain.sh ../missing ../mkinstalldirs ../ylwrap ChangeLog \
-	acconfig.h
+	../config.guess ../config.rpath ../config.sub ../depcomp \
+	../install-sh ../ltcf-c.sh ../ltcf-cxx.sh ../ltcf-gcj.sh \
+	../ltconfig ../ltmain.sh ../missing ../mkinstalldirs ../ylwrap \
+	ChangeLog acconfig.h
 subdir = .
 ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
 am__aclocal_m4_deps = $(top_srcdir)/acinclude.m4 \
@@ -156,6 +156,7 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
 INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@
 LIBICONV = @LIBICONV@
 LIBMATHOBJS = @LIBMATHOBJS@
+LIBMX = @LIBMX@
 LIBOBJS = @LIBOBJS@
 LIBS = @LIBS@
 LIBSUPCXX_PICFLAGS = @LIBSUPCXX_PICFLAGS@
@@ -570,7 +571,7 @@ distcheck: dist
 	*.tar.Z*) \
 	  uncompress -c $(distdir).tar.Z | $(AMTAR) xf - ;;\
 	*.shar.gz*) \
-	  GZIP=$(GZIP_ENV) gunzip -c $(distdir).tar.gz | unshar ;;\
+	  GZIP=$(GZIP_ENV) gunzip -c $(distdir).shar.gz | unshar ;;\
 	*.zip*) \
 	  unzip $(distdir).zip ;;\
 	esac
@@ -593,7 +594,7 @@ distcheck: dist
 	        distuninstallcheck \
 	  && chmod -R a-w "$$dc_install_base" \
 	  && ({ \
-	       (cd ../.. && $(mkdir_p) "$$dc_destdir") \
+	       (cd ../.. && umask 077 && mkdir "$$dc_destdir") \
 	       && $(MAKE) $(AM_MAKEFLAGS) DESTDIR="$$dc_destdir" install \
 	       && $(MAKE) $(AM_MAKEFLAGS) DESTDIR="$$dc_destdir" uninstall \
 	       && $(MAKE) $(AM_MAKEFLAGS) DESTDIR="$$dc_destdir" \
Index: aclocal.m4
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/aclocal.m4,v
retrieving revision 1.301
diff -u -p -r1.301 aclocal.m4
--- aclocal.m4	31 May 2004 21:19:50 -0000	1.301
+++ aclocal.m4	9 Jun 2004 00:07:36 -0000
@@ -1,4 +1,4 @@
-# generated automatically by aclocal 1.8.3 -*- Autoconf -*-
+# generated automatically by aclocal 1.8.5 -*- Autoconf -*-
 
 # Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004
 # Free Software Foundation, Inc.
@@ -40,7 +40,7 @@ AC_DEFUN([AM_AUTOMAKE_VERSION], [am__api
 # Call AM_AUTOMAKE_VERSION so it can be traced.
 # This function is AC_REQUIREd by AC_INIT_AUTOMAKE.
 AC_DEFUN([AM_SET_CURRENT_AUTOMAKE_VERSION],
-	 [AM_AUTOMAKE_VERSION([1.8.3])])
+	 [AM_AUTOMAKE_VERSION([1.8.5])])
 
 # AM_AUX_DIR_EXPAND
 
Index: configure
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/configure,v
retrieving revision 1.389
diff -u -p -r1.389 configure
--- configure	31 May 2004 21:19:50 -0000	1.389
+++ configure	9 Jun 2004 00:07:38 -0000
@@ -309,7 +309,7 @@ ac_includes_default="\
 # include <unistd.h>
 #endif"
 
-ac_subst_vars='SHELL PATH_SEPARATOR PACKAGE_NAME PACKAGE_TARNAME PACKAGE_VERSION PACKAGE_STRING PACKAGE_BUGREPORT exec_prefix prefix program_transform_name bindir sbindir libexecdir datadir sysconfdir sharedstatedir localstatedir libdir includedir oldincludedir infodir mandir build_alias host_alias target_alias DEFS ECHO_C ECHO_N ECHO_T LIBS libtool_VERSION multi_basedir build build_cpu build_vendor build_os host host_cpu host_vendor host_os target target_cpu target_vendor target_os INSTALL_PROGRAM INSTALL_SCRIPT INSTALL_DATA CYGPATH_W PACKAGE VERSION ACLOCAL AUTOCONF AUTOMAKE AUTOHEADER MAKEINFO AMTAR install_sh STRIP ac_ct_STRIP INSTALL_STRIP_PROGRAM mkdir_p AWK SET_MAKE am__leading_dot glibcxx_builddir glibcxx_srcdir toplevel_srcdir CC ac_ct_CC EXEEXT OBJEXT CXX ac_ct_CXX CFLAGS CXXFLAGS LN_S AS ac_ct_AS AR ac_ct_AR RANLIB ac_ct_RANLIB MAINTAINER_MODE_TRUE MAINTAINER_MODE_FALSE MAINT LIBTOOL CXXCPP CPPFLAGS enable_shared enable_static GLIBCXX_HOSTED_TRUE GLIBCXX_HOSTED_FALSE GLIBCXX_BUILD_PCH_TRUE GLIBCXX_BUILD_PCH_FALSE glibcxx_PCHFLAGS CSTDIO_H BASIC_FILE_H BASIC_FILE_CC CPP EGREP check_msgfmt glibcxx_MOFILES glibcxx_POFILES glibcxx_localedir USE_NLS CLOCALE_H CCODECVT_H CMESSAGES_H CCODECVT_CC CCOLLATE_CC CCTYPE_CC CMESSAGES_CC CMONEY_CC CNUMERIC_CC CTIME_H CTIME_CC CLOCALE_CC CLOCALE_INTERNAL_H ALLOCATOR_H ALLOCATOR_NAME C_INCLUDE_DIR GLIBCXX_C_HEADERS_C_TRUE GLIBCXX_C_HEADERS_C_FALSE GLIBCXX_C_HEADERS_C_STD_TRUE GLIBCXX_C_HEADERS_C_STD_FALSE GLIBCXX_C_HEADERS_COMPATIBILITY_TRUE GLIBCXX_C_HEADERS_COMPATIBILITY_FALSE glibcxx_thread_h DEBUG_FLAGS GLIBCXX_BUILD_DEBUG_TRUE GLIBCXX_BUILD_DEBUG_FALSE EXTRA_CXX_FLAGS WERROR SECTION_FLAGS SECTION_LDFLAGS OPT_LDFLAGS LIBMATHOBJS LIBICONV SYMVER_MAP port_specific_symbol_files GLIBCXX_BUILD_VERSIONED_SHLIB_TRUE GLIBCXX_BUILD_VERSIONED_SHLIB_FALSE baseline_dir GLIBCXX_TEST_WCHAR_T_TRUE GLIBCXX_TEST_WCHAR_T_FALSE GLIBCXX_TEST_ABI_TRUE GLIBCXX_TEST_ABI_FALSE ATOMICITY_SRCDIR ATOMIC_WORD_SRCDIR OS_INC_SRCDIR glibcxx_prefixdir gxx_include_dir glibcxx_toolexecdir glibcxx_toolexeclibdir GLIBCXX_INCLUDES TOPLEVEL_INCLUDES OPTIMIZE_CXXFLAGS WARN_FLAGS LIBSUPCXX_PICFLAGS LIBOBJS LTLIBOBJS'
+ac_subst_vars='SHELL PATH_SEPARATOR PACKAGE_NAME PACKAGE_TARNAME PACKAGE_VERSION PACKAGE_STRING PACKAGE_BUGREPORT exec_prefix prefix program_transform_name bindir sbindir libexecdir datadir sysconfdir sharedstatedir localstatedir libdir includedir oldincludedir infodir mandir build_alias host_alias target_alias DEFS ECHO_C ECHO_N ECHO_T LIBS libtool_VERSION multi_basedir build build_cpu build_vendor build_os host host_cpu host_vendor host_os target target_cpu target_vendor target_os INSTALL_PROGRAM INSTALL_SCRIPT INSTALL_DATA CYGPATH_W PACKAGE VERSION ACLOCAL AUTOCONF AUTOMAKE AUTOHEADER MAKEINFO AMTAR install_sh STRIP ac_ct_STRIP INSTALL_STRIP_PROGRAM mkdir_p AWK SET_MAKE am__leading_dot glibcxx_builddir glibcxx_srcdir toplevel_srcdir CC ac_ct_CC EXEEXT OBJEXT CXX ac_ct_CXX CFLAGS CXXFLAGS LN_S AS ac_ct_AS AR ac_ct_AR RANLIB ac_ct_RANLIB MAINTAINER_MODE_TRUE MAINTAINER_MODE_FALSE MAINT LIBTOOL CXXCPP CPPFLAGS enable_shared enable_static GLIBCXX_HOSTED_TRUE GLIBCXX_HOSTED_FALSE GLIBCXX_BUILD_PCH_TRUE GLIBCXX_BUILD_PCH_FALSE glibcxx_PCHFLAGS CSTDIO_H BASIC_FILE_H BASIC_FILE_CC CPP EGREP check_msgfmt glibcxx_MOFILES glibcxx_POFILES glibcxx_localedir USE_NLS CLOCALE_H CCODECVT_H CMESSAGES_H CCODECVT_CC CCOLLATE_CC CCTYPE_CC CMESSAGES_CC CMONEY_CC CNUMERIC_CC CTIME_H CTIME_CC CLOCALE_CC CLOCALE_INTERNAL_H ALLOCATOR_H ALLOCATOR_NAME C_INCLUDE_DIR GLIBCXX_C_HEADERS_C_TRUE GLIBCXX_C_HEADERS_C_FALSE GLIBCXX_C_HEADERS_C_STD_TRUE GLIBCXX_C_HEADERS_C_STD_FALSE GLIBCXX_C_HEADERS_COMPATIBILITY_TRUE GLIBCXX_C_HEADERS_COMPATIBILITY_FALSE glibcxx_thread_h DEBUG_FLAGS GLIBCXX_BUILD_DEBUG_TRUE GLIBCXX_BUILD_DEBUG_FALSE EXTRA_CXX_FLAGS WERROR SECTION_FLAGS SECTION_LDFLAGS OPT_LDFLAGS LIBMX LIBMATHOBJS LIBICONV SYMVER_MAP port_specific_symbol_files GLIBCXX_BUILD_VERSIONED_SHLIB_TRUE GLIBCXX_BUILD_VERSIONED_SHLIB_FALSE baseline_dir GLIBCXX_TEST_WCHAR_T_TRUE GLIBCXX_TEST_WCHAR_T_FALSE GLIBCXX_TEST_ABI_TRUE GLIBCXX_TEST_ABI_FALSE ATOMICITY_SRCDIR ATOMIC_WORD_SRCDIR OS_INC_SRCDIR glibcxx_prefixdir gxx_include_dir glibcxx_toolexecdir glibcxx_toolexeclibdir GLIBCXX_INCLUDES TOPLEVEL_INCLUDES OPTIMIZE_CXXFLAGS WARN_FLAGS LIBSUPCXX_PICFLAGS LIBOBJS LTLIBOBJS'
 ac_subst_files=''
 
 # Initialize some variables set by options.
@@ -8521,6 +8521,13 @@ if test $ac_cv_lib_mx_sqrtf = yes; then
 fi
 
     LIBS="$LIBS $libmx"
+  if x$libmx = x then
+    LIBMX=
+  else
+    LIBMX=-lmx
+  fi
+
+
 
 
 
@@ -31747,6 +31754,13 @@ if test $ac_cv_lib_mx_sqrtf = yes; then
 fi
 
     LIBS="$LIBS $libmx"
+  if x$libmx = x then
+    LIBMX=
+  else
+    LIBMX=-lmx
+  fi
+
+
 
 
 
@@ -74245,6 +74259,7 @@ s,@WERROR@,$WERROR,;t t
 s,@SECTION_FLAGS@,$SECTION_FLAGS,;t t
 s,@SECTION_LDFLAGS@,$SECTION_LDFLAGS,;t t
 s,@OPT_LDFLAGS@,$OPT_LDFLAGS,;t t
+s,@LIBMX@,$LIBMX,;t t
 s,@LIBMATHOBJS@,$LIBMATHOBJS,;t t
 s,@LIBICONV@,$LIBICONV,;t t
 s,@SYMVER_MAP@,$SYMVER_MAP,;t t
Index: linkage.m4
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/linkage.m4,v
retrieving revision 1.7
diff -u -p -r1.7 linkage.m4
--- linkage.m4	23 Apr 2004 20:06:56 -0000	1.7
+++ linkage.m4	9 Jun 2004 00:07:38 -0000
@@ -408,6 +408,13 @@ AC_DEFUN([GLIBCXX_CHECK_MATH_SUPPORT], [
   AC_CHECK_LIB(mx, sqrtf, libmx="-lmx")
   dnl ac_save_LIBS="$LIBS"
   LIBS="$LIBS $libmx"
+  if x$libmx = x then
+    LIBMX=
+  else
+    LIBMX=-lmx
+  fi
+
+  AC_SUBST(LIBMX)
 
   dnl Check to see if certain C math functions exist.
   GLIBCXX_CHECK_MATH_DECL_AND_LINKAGE_1(isinf)
Index: include/Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/include/Makefile.in,v
retrieving revision 1.101
diff -u -p -r1.101 Makefile.in
--- include/Makefile.in	19 Mar 2004 11:34:42 -0000	1.101
+++ include/Makefile.in	9 Jun 2004 00:07:38 -0000
@@ -1,4 +1,4 @@
-# Makefile.in generated by automake 1.8.2 from Makefile.am.
+# Makefile.in generated by automake 1.8.5 from Makefile.am.
 # @configure_input@
 
 # Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
@@ -124,6 +124,7 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
 INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@
 LIBICONV = @LIBICONV@
 LIBMATHOBJS = @LIBMATHOBJS@
+LIBMX = @LIBMX@
 LIBOBJS = @LIBOBJS@
 LIBS = @LIBS@
 LIBSUPCXX_PICFLAGS = @LIBSUPCXX_PICFLAGS@
Index: libmath/Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/libmath/Makefile.in,v
retrieving revision 1.96
diff -u -p -r1.96 Makefile.in
--- libmath/Makefile.in	19 Mar 2004 11:34:43 -0000	1.96
+++ libmath/Makefile.in	9 Jun 2004 00:07:38 -0000
@@ -1,4 +1,4 @@
-# Makefile.in generated by automake 1.8.2 from Makefile.am.
+# Makefile.in generated by automake 1.8.5 from Makefile.am.
 # @configure_input@
 
 # Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
@@ -141,6 +141,7 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
 INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@
 LIBICONV = @LIBICONV@
 LIBMATHOBJS = @LIBMATHOBJS@
+LIBMX = @LIBMX@
 LIBOBJS = @LIBOBJS@
 LIBS = @LIBS@
 LIBSUPCXX_PICFLAGS = @LIBSUPCXX_PICFLAGS@
@@ -278,7 +279,7 @@ clean-noinstLTLIBRARIES:
 	-test -z "$(noinst_LTLIBRARIES)" || rm -f $(noinst_LTLIBRARIES)
 	@list='$(noinst_LTLIBRARIES)'; for p in $$list; do \
 	  dir="`echo $$p | sed -e 's|/[^/]*$$||'`"; \
-	  test "$$dir" = "$$p" && dir=.; \
+	  test "$$dir" != "$$p" || dir=.; \
 	  echo "rm -f \"$${dir}/so_locations\""; \
 	  rm -f "$${dir}/so_locations"; \
 	done
@@ -330,9 +331,11 @@ TAGS:  $(HEADERS) $(SOURCES)  $(TAGS_DEP
 	  done | \
 	  $(AWK) '    { files[$$0] = 1; } \
 	       END { for (i in files) print i; }'`; \
-	test -z "$(ETAGS_ARGS)$$tags$$unique" \
-	  || $(ETAGS) $(ETAGSFLAGS) $(AM_ETAGSFLAGS) $(ETAGS_ARGS) \
-	     $$tags $$unique
+	if test -z "$(ETAGS_ARGS)$$tags$$unique"; then :; else \
+	  test -n "$$unique" || unique=$$empty_fix; \
+	  $(ETAGS) $(ETAGSFLAGS) $(AM_ETAGSFLAGS) $(ETAGS_ARGS) \
+	    $$tags $$unique; \
+	fi
 ctags: CTAGS
 CTAGS:  $(HEADERS) $(SOURCES)  $(TAGS_DEPENDENCIES) \
 		$(TAGS_FILES) $(LISP)
Index: libsupc++/Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/libsupc++/Makefile.in,v
retrieving revision 1.111
diff -u -p -r1.111 Makefile.in
--- libsupc++/Makefile.in	19 Mar 2004 11:34:44 -0000	1.111
+++ libsupc++/Makefile.in	9 Jun 2004 00:07:38 -0000
@@ -1,4 +1,4 @@
-# Makefile.in generated by automake 1.8.2 from Makefile.am.
+# Makefile.in generated by automake 1.8.5 from Makefile.am.
 # @configure_input@
 
 # Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
@@ -53,7 +53,7 @@ am__configure_deps = $(am__aclocal_m4_de
 	$(ACLOCAL_M4)
 CONFIG_HEADER = $(top_builddir)/config.h
 CONFIG_CLEAN_FILES =
-am__installdirs = $(DESTDIR)$(toolexeclibdir) $(DESTDIR)$(glibcxxinstalldir)
+am__installdirs = "$(DESTDIR)$(toolexeclibdir)" "$(DESTDIR)$(glibcxxinstalldir)"
 toolexeclibLTLIBRARIES_INSTALL = $(INSTALL)
 LTLIBRARIES = $(noinst_LTLIBRARIES) $(toolexeclib_LTLIBRARIES)
 libsupc___la_LIBADD =
@@ -159,6 +159,7 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
 INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@
 LIBICONV = @LIBICONV@
 LIBMATHOBJS = @LIBMATHOBJS@
+LIBMX = @LIBMX@
 LIBOBJS = @LIBOBJS@
 LIBS = @LIBS@
 LIBSUPCXX_PICFLAGS = @LIBSUPCXX_PICFLAGS@
@@ -419,18 +420,18 @@ clean-noinstLTLIBRARIES:
 	-test -z "$(noinst_LTLIBRARIES)" || rm -f $(noinst_LTLIBRARIES)
 	@list='$(noinst_LTLIBRARIES)'; for p in $$list; do \
 	  dir="`echo $$p | sed -e 's|/[^/]*$$||'`"; \
-	  test "$$dir" = "$$p" && dir=.; \
+	  test "$$dir" != "$$p" || dir=.; \
 	  echo "rm -f \"$${dir}/so_locations\""; \
 	  rm -f "$${dir}/so_locations"; \
 	done
 install-toolexeclibLTLIBRARIES: $(toolexeclib_LTLIBRARIES)
 	@$(NORMAL_INSTALL)
-	$(mkdir_p) $(DESTDIR)$(toolexeclibdir)
+	test -z "$(toolexeclibdir)" || $(mkdir_p) "$(DESTDIR)$(toolexeclibdir)"
 	@list='$(toolexeclib_LTLIBRARIES)'; for p in $$list; do \
 	  if test -f $$p; then \
 	    f="`echo $$p | sed -e 's|^.*/||'`"; \
-	    echo " $(LIBTOOL) --mode=install $(toolexeclibLTLIBRARIES_INSTALL) $(INSTALL_STRIP_FLAG) $$p $(DESTDIR)$(toolexeclibdir)/$$f"; \
-	    $(LIBTOOL) --mode=install $(toolexeclibLTLIBRARIES_INSTALL) $(INSTALL_STRIP_FLAG) $$p $(DESTDIR)$(toolexeclibdir)/$$f; \
+	    echo " $(LIBTOOL) --mode=install $(toolexeclibLTLIBRARIES_INSTALL) $(INSTALL_STRIP_FLAG) '$$p' '$(DESTDIR)$(toolexeclibdir)/$$f'"; \
+	    $(LIBTOOL) --mode=install $(toolexeclibLTLIBRARIES_INSTALL) $(INSTALL_STRIP_FLAG) "$$p" "$(DESTDIR)$(toolexeclibdir)/$$f"; \
 	  else :; fi; \
 	done
 
@@ -438,15 +439,15 @@ uninstall-toolexeclibLTLIBRARIES:
 	@$(NORMAL_UNINSTALL)
 	@list='$(toolexeclib_LTLIBRARIES)'; for p in $$list; do \
 	    p="`echo $$p | sed -e 's|^.*/||'`"; \
-	  echo " $(LIBTOOL) --mode=uninstall rm -f $(DESTDIR)$(toolexeclibdir)/$$p"; \
-	  $(LIBTOOL) --mode=uninstall rm -f $(DESTDIR)$(toolexeclibdir)/$$p; \
+	  echo " $(LIBTOOL) --mode=uninstall rm -f '$(DESTDIR)$(toolexeclibdir)/$$p'"; \
+	  $(LIBTOOL) --mode=uninstall rm -f "$(DESTDIR)$(toolexeclibdir)/$$p"; \
 	done
 
 clean-toolexeclibLTLIBRARIES:
 	-test -z "$(toolexeclib_LTLIBRARIES)" || rm -f $(toolexeclib_LTLIBRARIES)
 	@list='$(toolexeclib_LTLIBRARIES)'; for p in $$list; do \
 	  dir="`echo $$p | sed -e 's|/[^/]*$$||'`"; \
-	  test "$$dir" = "$$p" && dir=.; \
+	  test "$$dir" != "$$p" || dir=.; \
 	  echo "rm -f \"$${dir}/so_locations\""; \
 	  rm -f "$${dir}/so_locations"; \
 	done
@@ -509,9 +510,11 @@ TAGS:  $(HEADERS) $(SOURCES)  $(TAGS_DEP
 	  done | \
 	  $(AWK) '    { files[$$0] = 1; } \
 	       END { for (i in files) print i; }'`; \
-	test -z "$(ETAGS_ARGS)$$tags$$unique" \
-	  || $(ETAGS) $(ETAGSFLAGS) $(AM_ETAGSFLAGS) $(ETAGS_ARGS) \
-	     $$tags $$unique
+	if test -z "$(ETAGS_ARGS)$$tags$$unique"; then :; else \
+	  test -n "$$unique" || unique=$$empty_fix; \
+	  $(ETAGS) $(ETAGSFLAGS) $(AM_ETAGSFLAGS) $(ETAGS_ARGS) \
+	    $$tags $$unique; \
+	fi
 ctags: CTAGS
 CTAGS:  $(HEADERS) $(SOURCES)  $(TAGS_DEPENDENCIES) \
 		$(TAGS_FILES) $(LISP)
@@ -567,7 +570,9 @@ check-am: all-am
 check: check-am
 all-am: Makefile $(LTLIBRARIES) $(HEADERS)
 installdirs:
-	$(mkdir_p) $(DESTDIR)$(toolexeclibdir) $(DESTDIR)$(glibcxxinstalldir)
+	for dir in "$(DESTDIR)$(toolexeclibdir)" "$(DESTDIR)$(glibcxxinstalldir)"; do \
+	  test -z "$$dir" || $(mkdir_p) "$$dir"; \
+	done
 install: install-am
 install-exec: install-exec-am
 install-data: install-data-am
Index: po/Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/po/Makefile.in,v
retrieving revision 1.41
diff -u -p -r1.41 Makefile.in
--- po/Makefile.in	19 Mar 2004 11:34:45 -0000	1.41
+++ po/Makefile.in	9 Jun 2004 00:07:38 -0000
@@ -1,4 +1,4 @@
-# Makefile.in generated by automake 1.8.2 from Makefile.am.
+# Makefile.in generated by automake 1.8.5 from Makefile.am.
 # @configure_input@
 
 # Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
@@ -124,6 +124,7 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
 INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@
 LIBICONV = @LIBICONV@
 LIBMATHOBJS = @LIBMATHOBJS@
+LIBMX = @LIBMX@
 LIBOBJS = @LIBOBJS@
 LIBS = @LIBS@
 LIBSUPCXX_PICFLAGS = @LIBSUPCXX_PICFLAGS@
Index: src/Makefile.am
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/src/Makefile.am,v
retrieving revision 1.144
diff -u -p -r1.144 Makefile.am
--- src/Makefile.am	16 Apr 2004 19:04:05 -0000	1.144
+++ src/Makefile.am	9 Jun 2004 00:07:38 -0000
@@ -147,8 +147,10 @@ libstdc___la_LIBADD = \
 
 libstdc___la_DEPENDENCIES = ${version_dep} $(libstdc___la_LIBADD)
 
+LIBMX = @LIBMX@
+
 libstdc___la_LDFLAGS = \
-	-version-info $(libtool_VERSION) ${version_arg} -lm 
+	-version-info $(libtool_VERSION) ${version_arg} -lm  $(LIBMX)
 
 
 # Use special rules for the deprecated source files so that they find
Index: src/Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/src/Makefile.in,v
retrieving revision 1.203
diff -u -p -r1.203 Makefile.in
--- src/Makefile.in	16 Apr 2004 19:04:05 -0000	1.203
+++ src/Makefile.in	9 Jun 2004 00:07:38 -0000
@@ -1,4 +1,4 @@
-# Makefile.in generated by automake 1.8.2 from Makefile.am.
+# Makefile.in generated by automake 1.8.5 from Makefile.am.
 # @configure_input@
 
 # Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
@@ -51,7 +51,7 @@ am__configure_deps = $(am__aclocal_m4_de
 	$(ACLOCAL_M4)
 CONFIG_HEADER = $(top_builddir)/config.h
 CONFIG_CLEAN_FILES =
-am__installdirs = $(DESTDIR)$(toolexeclibdir)
+am__installdirs = "$(DESTDIR)$(toolexeclibdir)"
 toolexeclibLTLIBRARIES_INSTALL = $(INSTALL)
 LTLIBRARIES = $(toolexeclib_LTLIBRARIES)
 am__objects_1 = atomicity.lo codecvt_members.lo collate_members.lo \
@@ -152,6 +152,7 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
 INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@
 LIBICONV = @LIBICONV@
 LIBMATHOBJS = @LIBMATHOBJS@
+LIBMX = @LIBMX@
 LIBOBJS = @LIBOBJS@
 LIBS = @LIBS@
 LIBSUPCXX_PICFLAGS = @LIBSUPCXX_PICFLAGS@
@@ -342,7 +343,7 @@ libstdc___la_LIBADD = \
 
 libstdc___la_DEPENDENCIES = ${version_dep} $(libstdc___la_LIBADD)
 libstdc___la_LDFLAGS = \
-	-version-info $(libtool_VERSION) ${version_arg} -lm 
+	-version-info $(libtool_VERSION) ${version_arg} -lm  $(LIBMX)
 
 
 # Use special rules for the deprecated source files so that they find
@@ -428,12 +429,12 @@ $(ACLOCAL_M4): @MAINTAINER_MODE_TRUE@ $(
 	cd $(top_builddir) && $(MAKE) $(AM_MAKEFLAGS) am--refresh
 install-toolexeclibLTLIBRARIES: $(toolexeclib_LTLIBRARIES)
 	@$(NORMAL_INSTALL)
-	$(mkdir_p) $(DESTDIR)$(toolexeclibdir)
+	test -z "$(toolexeclibdir)" || $(mkdir_p) "$(DESTDIR)$(toolexeclibdir)"
 	@list='$(toolexeclib_LTLIBRARIES)'; for p in $$list; do \
 	  if test -f $$p; then \
 	    f="`echo $$p | sed -e 's|^.*/||'`"; \
-	    echo " $(LIBTOOL) --mode=install $(toolexeclibLTLIBRARIES_INSTALL) $(INSTALL_STRIP_FLAG) $$p $(DESTDIR)$(toolexeclibdir)/$$f"; \
-	    $(LIBTOOL) --mode=install $(toolexeclibLTLIBRARIES_INSTALL) $(INSTALL_STRIP_FLAG) $$p $(DESTDIR)$(toolexeclibdir)/$$f; \
+	    echo " $(LIBTOOL) --mode=install $(toolexeclibLTLIBRARIES_INSTALL) $(INSTALL_STRIP_FLAG) '$$p' '$(DESTDIR)$(toolexeclibdir)/$$f'"; \
+	    $(LIBTOOL) --mode=install $(toolexeclibLTLIBRARIES_INSTALL) $(INSTALL_STRIP_FLAG) "$$p" "$(DESTDIR)$(toolexeclibdir)/$$f"; \
 	  else :; fi; \
 	done
 
@@ -441,15 +442,15 @@ uninstall-toolexeclibLTLIBRARIES:
 	@$(NORMAL_UNINSTALL)
 	@list='$(toolexeclib_LTLIBRARIES)'; for p in $$list; do \
 	    p="`echo $$p | sed -e 's|^.*/||'`"; \
-	  echo " $(LIBTOOL) --mode=uninstall rm -f $(DESTDIR)$(toolexeclibdir)/$$p"; \
-	  $(LIBTOOL) --mode=uninstall rm -f $(DESTDIR)$(toolexeclibdir)/$$p; \
+	  echo " $(LIBTOOL) --mode=uninstall rm -f '$(DESTDIR)$(toolexeclibdir)/$$p'"; \
+	  $(LIBTOOL) --mode=uninstall rm -f "$(DESTDIR)$(toolexeclibdir)/$$p"; \
 	done
 
 clean-toolexeclibLTLIBRARIES:
 	-test -z "$(toolexeclib_LTLIBRARIES)" || rm -f $(toolexeclib_LTLIBRARIES)
 	@list='$(toolexeclib_LTLIBRARIES)'; for p in $$list; do \
 	  dir="`echo $$p | sed -e 's|/[^/]*$$||'`"; \
-	  test "$$dir" = "$$p" && dir=.; \
+	  test "$$dir" != "$$p" || dir=.; \
 	  echo "rm -f \"$${dir}/so_locations\""; \
 	  rm -f "$${dir}/so_locations"; \
 	done
@@ -501,9 +502,11 @@ TAGS:  $(HEADERS) $(SOURCES)  $(TAGS_DEP
 	  done | \
 	  $(AWK) '    { files[$$0] = 1; } \
 	       END { for (i in files) print i; }'`; \
-	test -z "$(ETAGS_ARGS)$$tags$$unique" \
-	  || $(ETAGS) $(ETAGSFLAGS) $(AM_ETAGSFLAGS) $(ETAGS_ARGS) \
-	     $$tags $$unique
+	if test -z "$(ETAGS_ARGS)$$tags$$unique"; then :; else \
+	  test -n "$$unique" || unique=$$empty_fix; \
+	  $(ETAGS) $(ETAGSFLAGS) $(AM_ETAGSFLAGS) $(ETAGS_ARGS) \
+	    $$tags $$unique; \
+	fi
 ctags: CTAGS
 CTAGS:  $(HEADERS) $(SOURCES)  $(TAGS_DEPENDENCIES) \
 		$(TAGS_FILES) $(LISP)
@@ -559,7 +562,9 @@ check-am: all-am
 check: check-am
 all-am: Makefile $(LTLIBRARIES) all-local
 installdirs:
-	$(mkdir_p) $(DESTDIR)$(toolexeclibdir)
+	for dir in "$(DESTDIR)$(toolexeclibdir)"; do \
+	  test -z "$$dir" || $(mkdir_p) "$$dir"; \
+	done
 install: install-am
 install-exec: install-exec-am
 install-data: install-data-am
Index: testsuite/Makefile.in
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/testsuite/Makefile.in,v
retrieving revision 1.75
diff -u -p -r1.75 Makefile.in
--- testsuite/Makefile.in	13 May 2004 12:50:53 -0000	1.75
+++ testsuite/Makefile.in	9 Jun 2004 00:07:38 -0000
@@ -1,4 +1,4 @@
-# Makefile.in generated by automake 1.8.2 from Makefile.am.
+# Makefile.in generated by automake 1.8.5 from Makefile.am.
 # @configure_input@
 
 # Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
@@ -54,8 +54,8 @@ am__configure_deps = $(am__aclocal_m4_de
 	$(ACLOCAL_M4)
 CONFIG_HEADER = $(top_builddir)/config.h
 CONFIG_CLEAN_FILES =
-ARFLAGS = cru
 LIBRARIES = $(noinst_LIBRARIES)
+ARFLAGS = cru
 libv3test_a_AR = $(AR) $(ARFLAGS)
 libv3test_a_LIBADD =
 am_libv3test_a_OBJECTS = testsuite_abi.$(OBJEXT) \
@@ -153,6 +153,7 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
 INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@
 LIBICONV = @LIBICONV@
 LIBMATHOBJS = @LIBMATHOBJS@
+LIBMX = @LIBMX@
 LIBOBJS = @LIBOBJS@
 LIBS = @LIBS@
 LIBSUPCXX_PICFLAGS = @LIBSUPCXX_PICFLAGS@
@@ -406,9 +407,11 @@ TAGS:  $(HEADERS) $(SOURCES)  $(TAGS_DEP
 	  done | \
 	  $(AWK) '    { files[$$0] = 1; } \
 	       END { for (i in files) print i; }'`; \
-	test -z "$(ETAGS_ARGS)$$tags$$unique" \
-	  || $(ETAGS) $(ETAGSFLAGS) $(AM_ETAGSFLAGS) $(ETAGS_ARGS) \
-	     $$tags $$unique
+	if test -z "$(ETAGS_ARGS)$$tags$$unique"; then :; else \
+	  test -n "$$unique" || unique=$$empty_fix; \
+	  $(ETAGS) $(ETAGSFLAGS) $(AM_ETAGSFLAGS) $(ETAGS_ARGS) \
+	    $$tags $$unique; \
+	fi
 ctags: CTAGS
 CTAGS:  $(HEADERS) $(SOURCES)  $(TAGS_DEPENDENCIES) \
 		$(TAGS_FILES) $(LISP)

Re: [patch] testsuite fix for math tests on darwin

[Gabriel Dos Reis]

You Wrote Andrew Pinski
>>
>>
>> >Yes I already did for the C++ driver but I did not know why the
>> testcases
>> >are still failing.  I will look into them when I figure out what is
>> wrong
>> >with my hard drive in my laptop.
>>
>> I'm seeing results consistent with:
>> http://gcc.gnu.org/ml/gcc-testresults/2004-06/msg00097.html
>>
>
> I think everyone at Apple is busy with WWDC related stuff.
> I made this patch which should fix it but I have not tested it.  Could
> someone test it for me?

This was basically discussed recently:  someone (at Apple) needs to
fix the gcc driver on Darwin so that it passes -lmx automatically
to the linker.
Ortherwise, we get nth annoying instances of the same problem.

>
> Thanks,
> Andrew Pinski
>
>

Re: [patch] testsuite fix for math tests on darwin

[Benjamin Kosnik]

>This was basically discussed recently:  someone (at Apple) needs to
>fix the gcc driver on Darwin so that it passes -lmx automatically
>to the linker. Ortherwise, we get nth annoying instances of the same problem.

Yes, I agree.

It looks, however, that some of this has already crept in.

less linkage.m4

  dnl Check libmx
  AC_CHECK_LIB(mx, sqrtf, libmx="-lmx")
  dnl ac_save_LIBS="$LIBS"
  LIBS="$LIBS $libmx"
 
It would be nice to have this done one way.

-benjamin

Re: [patch] testsuite fix for math tests on darwin

[Andrew Pinski]

> 
> 
> >This was basically discussed recently:  someone (at Apple) needs to
> >fix the gcc driver on Darwin so that it passes -lmx automatically
> >to the linker. Ortherwise, we get nth annoying instances of the same problem.
> 
> Yes, I agree.
> 
> It looks, however, that some of this has already crept in.
> 
> less linkage.m4
> 
>   dnl Check libmx
>   AC_CHECK_LIB(mx, sqrtf, libmx="-lmx")
>   dnl ac_save_LIBS="$LIBS"
>   LIBS="$LIBS $libmx"
>  
> It would be nice to have this done one way.

That is still needed unless just as -lm check above is needed.
No the testsuite failures are coming from the fact the dejgnu adds
-lm to the link line which causes g++ not to add -lmx because there
is a check in the driver for -lmx when there should not be as this
would not be constaint with gfortran and would be bad behavior where
on other targets where the MATH_LIBRARY was named different also.

So this patch which removes that check for -lm and also removes it for
-lmath, these look like they were done before MATH_LIBRARY was around
so they become redundent.


Bootstrapped on powerpc-apple-darwin with no regressions and those test
cases passes now.

Thanks,
Andrew Pinski

ChangeLog:
	* g++spec.c (lang_specific_driver): Remove check for -lm
	and -lmath when check it see if it was the math library.

Patch:
Index: g++spec.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/cp/g++spec.c,v
retrieving revision 1.41
diff -u -p -r1.41 g++spec.c
--- g++spec.c   4 Dec 2003 06:07:03 -0000       1.41
+++ g++spec.c   9 Jun 2004 16:40:47 -0000
@@ -136,10 +136,7 @@ lang_specific_driver (int *in_argc, cons
            {
              library = -1;
            }
-         else if (strcmp (argv[i], "-lm") == 0
-                  || strcmp (argv[i], "-lmath") == 0
-                  || strcmp (argv[i], MATH_LIBRARY) == 0
-                 )
+         else if (strcmp (argv[i], MATH_LIBRARY) == 0)
            {
              args[i] |= MATHLIB;
              need_math = 0;

Re: [patch] testsuite fix for math tests on darwin

[Benjamin Kosnik]

>So this patch which removes that check for -lm and also removes it for
>-lmath, these look like they were done before MATH_LIBRARY was around
>so they become redundent.
>
>
>Bootstrapped on powerpc-apple-darwin with no regressions and those test
>cases passes now.

Great. This looks good to me, but I cannot approve this. 

It would be nice if somebody else would, however....

-benjamin

Re: [patch] testsuite fix for math tests on darwin

[Geoff Keating]

Andrew Pinski <pinskia@physics.uc.edu> writes:

> ChangeLog:
> 	* g++spec.c (lang_specific_driver): Remove check for -lm
> 	and -lmath when check it see if it was the math library.

This is OK.  [Thanks to bkoz for pre-reviewing the patch.]

-- 
- Geoffrey Keating <geoffk@geoffk.org>