* [libobjc] committed, shared libraries
@ 2004-06-11 18:39 Andrew Pinski
2004-06-11 20:22 ` Joseph S. Myers
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Pinski @ 2004-06-11 18:39 UTC (permalink / raw)
To: gcc-patches
I noticed this while working on getting libobjc back running
on Darwin. Libobjc was disabling shared libaries by default
unlike the other target libraries. This patch fixes that
tested on powerpc-apple-darwin with a patch to the top level
configure to build libobjc there.
Thanks,
Andrew Pinski
2004-06-11 Andrew Pinski <pinskia@physics.uc.edu>
PR libobjc/15901
* configure.ac: Do not disable shared by default.
* configure: Regenerate.
Index: configure.ac
===================================================================
RCS file: /cvs/gcc/gcc/libobjc/configure.ac,v
retrieving revision 1.6
diff -u -p -r1.6 configure.ac
--- configure.ac 26 May 2004 01:21:46 -0000 1.6
+++ configure.ac 11 Jun 2004 17:36:21 -0000
@@ -189,8 +189,6 @@ AC_CHECK_TOOL(AR, ar)
AC_CHECK_TOOL(RANLIB, ranlib, :)
AC_PROG_INSTALL
-# Disable shared libs by default
-AC_DISABLE_SHARED
# Enable Win32 DLL on MS Windows - FIXME
AC_LIBTOOL_WIN32_DLL
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [libobjc] committed, shared libraries 2004-06-11 18:39 [libobjc] committed, shared libraries Andrew Pinski @ 2004-06-11 20:22 ` Joseph S. Myers 2004-06-11 20:59 ` Andrew Pinski 0 siblings, 1 reply; 6+ messages in thread From: Joseph S. Myers @ 2004-06-11 20:22 UTC (permalink / raw) To: Andrew Pinski; +Cc: gcc-patches On Fri, 11 Jun 2004, Andrew Pinski wrote: > I noticed this while working on getting libobjc back running > on Darwin. Libobjc was disabling shared libaries by default > unlike the other target libraries. This patch fixes that > tested on powerpc-apple-darwin with a patch to the top level > configure to build libobjc there. You need to update the documentation of --enable-shared to reflect this change. If --enable-shared=libobjc is recognised, the documentation should reflect that as well. (Do libgfortran and libmudflap have --enable-shared=package configure options? The documentation doesn't say either way.) In addition, the documentation of --enable-version-specific-runtime-libs says it is the default for libobjc, which no longer seems accurate. -- Joseph S. Myers jsm@polyomino.org.uk ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [libobjc] committed, shared libraries 2004-06-11 20:22 ` Joseph S. Myers @ 2004-06-11 20:59 ` Andrew Pinski 2004-06-11 21:19 ` Andrew Pinski 0 siblings, 1 reply; 6+ messages in thread From: Andrew Pinski @ 2004-06-11 20:59 UTC (permalink / raw) To: Joseph S. Myers; +Cc: Andrew Pinski, gcc-patches > > On Fri, 11 Jun 2004, Andrew Pinski wrote: > > > I noticed this while working on getting libobjc back running > > on Darwin. Libobjc was disabling shared libaries by default > > unlike the other target libraries. This patch fixes that > > tested on powerpc-apple-darwin with a patch to the top level > > configure to build libobjc there. > > You need to update the documentation of --enable-shared to reflect this > change. > > If --enable-shared=libobjc is recognised, the documentation should reflect > that as well. (Do libgfortran and libmudflap have --enable-shared=package > configure options? The documentation doesn't say either way.) In > addition, the documentation of --enable-version-specific-runtime-libs says > it is the default for libobjc, which no longer seems accurate. Woops I do not noticed the documenation. This will fixed with my next patch after this one which adds support for --enable-shared=libobjc which I committed after testing it. Thanks, Andrew Pinski 2004-06-11 Andrew Pinski <pinskia@physics.uc.edu> * configure.ac: Support --enable-shared=libobjc. * configure: Regenerate. Patch: Index: configure.ac =================================================================== RCS file: /cvs/gcc/gcc/libobjc/configure.ac,v retrieving revision 1.7 diff -u -p -r1.7 configure.ac --- configure.ac 11 Jun 2004 17:37:06 -0000 1.7 +++ configure.ac 11 Jun 2004 20:10:26 -0000 @@ -21,7 +21,7 @@ #02111-1307, USA. AC_PREREQ(2.59) -AC_INIT +AC_INIT(package-unused, version-unused,, libobjc) AC_CONFIG_SRCDIR([objc/objc.h]) # We need the following definitions because AC_PROG_LIBTOOL relies on them ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [libobjc] committed, shared libraries 2004-06-11 20:59 ` Andrew Pinski @ 2004-06-11 21:19 ` Andrew Pinski 2004-06-11 21:22 ` Joseph S. Myers 2004-06-11 21:39 ` Andrew Pinski 0 siblings, 2 replies; 6+ messages in thread From: Andrew Pinski @ 2004-06-11 21:19 UTC (permalink / raw) To: Andrew Pinski; +Cc: Joseph S. Myers, Andrew Pinski, gcc-patches > > > > > On Fri, 11 Jun 2004, Andrew Pinski wrote: > > > > > I noticed this while working on getting libobjc back running > > > on Darwin. Libobjc was disabling shared libaries by default > > > unlike the other target libraries. This patch fixes that > > > tested on powerpc-apple-darwin with a patch to the top level > > > configure to build libobjc there. > > > > You need to update the documentation of --enable-shared to reflect this > > change. > > > > If --enable-shared=libobjc is recognised, the documentation should reflect > > that as well. (Do libgfortran and libmudflap have --enable-shared=package > > configure options? The documentation doesn't say either way.) In > > addition, the documentation of --enable-version-specific-runtime-libs says > > it is the default for libobjc, which no longer seems accurate. > > Woops I do not noticed the documenation. This will fixed with my next patch > after this one which adds support for --enable-shared=libobjc which I committed > after testing it. > And here is the patch which updates the documenation, it also removes the reference libf2c which was wrong any ways. Also --enable-version-specific-runtime-libs is still the default for libobjc as the headers are still installed in ${libdir}/gcc/${version}/${target}/include. Thanks, Andrew Pinski ChangeLog: * doc/install.texi (--enable-shared): Update libobjc's shared library status. Remove reference to libf2c. Index: install.texi =================================================================== RCS file: /cvs/gcc/gcc/gcc/doc/install.texi,v retrieving revision 1.286 diff -u -p -r1.286 install.texi --- install.texi 11 Jun 2004 16:50:08 -0000 1.286 +++ install.texi 11 Jun 2004 20:12:04 -0000 @@ -756,20 +756,15 @@ installing GCC creates the directory. @item --enable-shared[=@var{package}[,@dots{}]] Build shared versions of libraries, if shared libraries are supported on the target platform. Unlike GCC 2.95.x and earlier, shared libraries -are enabled by default on all platforms that support shared libraries, -except for @samp{libobjc} which is built as a static library only by -default. +are enabled by default on all platforms that support shared libraries. If a list of packages is given as an argument, build shared libraries only for the listed packages. For other packages, only static libraries will be built. Package names currently recognized in the GCC tree are @samp{libgcc} (also known as @samp{gcc}), @samp{libstdc++} (not @samp{libstdc++-v3}), @samp{libffi}, @samp{zlib}, @samp{boehm-gc}, -@samp{ada}, @samp{libada} and @samp{libjava}. -Note that @samp{libobjc} does not recognize itself by -any name, so, if you list package names in @option{--enable-shared}, -you will only get static Objective-C libraries. @samp{libf2c} and -@samp{libiberty} do not support shared libraries at all. +@samp{ada}, @samp{libada}, @samp{libjava} and @samp{libobjc}. +Note @samp{libiberty} do not support shared libraries at all. Use @option{--disable-shared} to build only static libraries. Note that @option{--disable-shared} does not accept a list of package names as ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [libobjc] committed, shared libraries 2004-06-11 21:19 ` Andrew Pinski @ 2004-06-11 21:22 ` Joseph S. Myers 2004-06-11 21:39 ` Andrew Pinski 1 sibling, 0 replies; 6+ messages in thread From: Joseph S. Myers @ 2004-06-11 21:22 UTC (permalink / raw) To: Andrew Pinski; +Cc: gcc-patches On Fri, 11 Jun 2004, Andrew Pinski wrote: > And here is the patch which updates the documenation, it also removes > the reference libf2c which was wrong any ways. Also > --enable-version-specific-runtime-libs is still the default for libobjc > as the headers are still installed in > ${libdir}/gcc/${version}/${target}/include. --enable-version-specific-runtime-libs is described as installing the libraries, not the headers, in the version-specific directory. It is not any longer the case that libobjc.{a,so} go in that directory by default. Installing the libstdc++ headers in a different place is described as an additional side-effect rather than the main purpose of the option. -- Joseph S. Myers jsm@polyomino.org.uk ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [libobjc] committed, shared libraries 2004-06-11 21:19 ` Andrew Pinski 2004-06-11 21:22 ` Joseph S. Myers @ 2004-06-11 21:39 ` Andrew Pinski 1 sibling, 0 replies; 6+ messages in thread From: Andrew Pinski @ 2004-06-11 21:39 UTC (permalink / raw) To: Andrew Pinski; +Cc: Andrew Pinski, Joseph S. Myers, gcc-patches > +Note @samp{libiberty} do not support shared libraries at all. I was pointed out that the verb should be "does" instead of "do". 2004-06-11 Andrew Pinski <pinskia@physics.uc.edu> * doc/install.text (--enable-shared): Fix typo. Index: doc/install.texi =================================================================== RCS file: /cvs/gcc/gcc/gcc/doc/install.texi,v retrieving revision 1.287 diff -u -p -r1.287 install.texi --- doc/install.texi 11 Jun 2004 20:17:46 -0000 1.287 +++ doc/install.texi 11 Jun 2004 20:26:02 -0000 @@ -764,7 +764,7 @@ will be built. Package names currently @samp{libgcc} (also known as @samp{gcc}), @samp{libstdc++} (not @samp{libstdc++-v3}), @samp{libffi}, @samp{zlib}, @samp{boehm-gc}, @samp{ada}, @samp{libada}, @samp{libjava} and @samp{libobjc}. -Note @samp{libiberty} do not support shared libraries at all. +Note @samp{libiberty} does not support shared libraries at all. Use @option{--disable-shared} to build only static libraries. Note that @option{--disable-shared} does not accept a list of package names as ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-06-11 20:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2004-06-11 18:39 [libobjc] committed, shared libraries Andrew Pinski 2004-06-11 20:22 ` Joseph S. Myers 2004-06-11 20:59 ` Andrew Pinski 2004-06-11 21:19 ` Andrew Pinski 2004-06-11 21:22 ` Joseph S. Myers 2004-06-11 21:39 ` Andrew Pinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).