Re: [PATCH] xcoff stabs -- fix typo and extra check

Re: [PATCH] xcoff stabs -- fix typo and extra check

[George Helffrich]

>>>> David Edelsohn writes:

>  	dbxout.c set current_sym_code to N_GSYM in exactly one place:

>        if (TREE_PUBLIC (decl))
>          {
>            letter = 'G';
>            current_sym_code = N_GSYM;
>          }

It won't be superfluous any more if this is approved

   http://gcc.gnu.org/ml/gcc-patches/2004-06/msg02096.html

because .comm syms will get N_GSYM set too, but they won't ever
have TREE_PUBLIC true.

                                       George

Re: [PATCH] xcoff stabs -- fix typo and extra check

[David Edelsohn]

>>>>> George Helffrich writes:

George> It won't be superfluous any more if this is approved

George> http://gcc.gnu.org/ml/gcc-patches/2004-06/msg02096.html

George> because .comm syms will get N_GSYM set too, but they won't ever
George> have TREE_PUBLIC true.

	And why isn't that a bug in your patch?

	All changes and co-dependencies associated with your patch should
be proposed with the patch so that they all will be reviewed togeher.

David

Re: [PATCH] xcoff stabs -- fix typo and extra check

[David Edelsohn]

	Fixing the typo from "sym" to "SYM" is fine and probably
considered obvious.

	The patch does not have any explanation for the extra TREE_PUBLIC
test.  I infer that you are using it as an assert, but the change is not
an assert -- it will generate incorrect debugging information if the test
fails.

	dbxout.c set current_sym_code to N_GSYM in exactly one place:

      if (TREE_PUBLIC (decl))
        {
          letter = 'G';
          current_sym_code = N_GSYM;
        }

So I do not think that you need to worry about it being set when
TREE_PUBLIC is not true and the extra test is superfluous.

	I will commit the typo fix.

David

[PATCH] xcoff stabs -- fix typo and extra check

[George Helffrich +44 117 954 5437]

This patch fixes a typo in the DBX_FINISH_SYMBOL macro, and adds an extra
check for N_GSYM symbol output.  It is independent of, but ensures proper
behavior with proposed patch

   http://gcc.gnu.org/ml/gcc-patches/2004-06/msg02096.html

                                       George

Index: gcc/xcoffout.h
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/xcoffout.h,v
retrieving revision 1.21
diff -u -r1.21 xcoffout.h
--- gcc/xcoffout.h	6 Jul 2003 16:53:23 -0000	1.21
+++ gcc/xcoffout.h	27 Jun 2004 14:15:08 -0000
@@ -97,8 +97,8 @@
     }								\
   else if (current_sym_addr)					\
     output_addr_const (asmfile, current_sym_addr);		\
-  else if (current_sym_code == N_GSYM)				\
-    assemble_name (asmfile, XSTR (XEXP (DECL_RTL (sym), 0), 0)); \
+  else if (current_sym_code == N_GSYM && TREE_PUBLIC (SYM))	\
+    assemble_name (asmfile, XSTR (XEXP (DECL_RTL (SYM), 0), 0)); \
   else								\
     fprintf (asmfile, "%d", current_sym_value);			\
   fprintf (asmfile, ",%d,0\n", stab_to_sclass (current_sym_code)); \
Index: gcc/ChangeLog
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/ChangeLog,v
retrieving revision 2.2326.2.399
diff -u -r2.2326.2.399 ChangeLog
--- gcc/ChangeLog	19 Apr 2004 01:58:10 -0000	2.2326.2.399
+++ gcc/ChangeLog	27 Jun 2004 14:24:10 -0000
@@ -1,3 +1,8 @@
+2004-06-27  George Helffrich <george@gly.bris.ac.uk>
+
+	* xcoffout.h: Fix typo and add check for symbol scope in
+	DBX_FINISH_SYMBOL
+
 2004-04-18  Release Manager
 
 	* GCC 3.4.0 released.