From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13146 invoked by alias); 7 Jul 2004 20:30:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13136 invoked from network); 7 Jul 2004 20:29:59 -0000 Received: from unknown (HELO hiauly1.hia.nrc.ca) (132.246.100.193) by sourceware.org with SMTP; 7 Jul 2004 20:29:59 -0000 Received: from hiauly1.hia.nrc.ca (hiauly1.hia.nrc.ca [127.0.0.1] (may be forged)) by hiauly1.hia.nrc.ca (8.12.9-20030917/8.12.9) with ESMTP id i67KTuCp011811; Wed, 7 Jul 2004 16:29:57 -0400 (EDT) Received: (from dave@localhost) by hiauly1.hia.nrc.ca (8.12.9-20030917/8.12.9/Submit) id i67KTulq011810; Wed, 7 Jul 2004 16:29:56 -0400 (EDT) Message-Id: <200407072029.i67KTulq011810@hiauly1.hia.nrc.ca> Subject: Re: [PATCH] Fix PR target/16344 To: dave@hiauly1.hia.nrc.ca (John David Anglin) Date: Wed, 07 Jul 2004 21:10:00 -0000 From: "John David Anglin" Cc: mark@codesourcery.com, geoffk@geoffk.org, gcc-patches@gcc.gnu.org In-Reply-To: from "John David Anglin" at Jul 7, 2004 01:26:06 am MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg00662.txt.bz2 > The problem is the PLT is moving from one invocation of cc1plus to > another. I'm not sure why. Currently, function descriptors live in > the PLT. So, if it moves, the PCH is dead even if the text is in the > same location as it was when the PCH file was written. If this can't > be fixed, then the only solution is to avoid writing out any function > pointers. It turns out that the PLT isn't moving. The problem is a Makefile issue. The runtime libraries are being built with the training compiler in a profiled build. Then, we use the profiled feedback compiler when the testsuite is run. As a result, PCH is disabled. I am testing the enclosed fix. Dave -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602) 2004-07-07 John David Anglin PR target/16344 * Makefile.tpl: Build runtime libraries with feedback based compiler. Index: Makefile.tpl =================================================================== RCS file: /cvs/gcc/gcc/Makefile.tpl,v retrieving revision 1.79 diff -u -3 -p -r1.79 Makefile.tpl --- Makefile.tpl 14 Jan 2004 20:09:37 -0000 1.79 +++ Makefile.tpl 7 Jul 2004 20:11:09 -0000 @@ -1177,18 +1177,18 @@ profiledbootstrap: all-bootstrap configu @r=`${PWD_COMMAND}`; export r; \ s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ $(SET_LIB_PATH) \ - echo "Bootstrapping the compiler"; \ + echo "Bootstrapping the training compiler"; \ cd gcc && $(MAKE) $(GCC_FLAGS_TO_PASS) stageprofile_build @r=`${PWD_COMMAND}`; export r; \ - s=`cd $(srcdir); ${PWD_COMMAND}` ; export s; \ - $(SET_LIB_PATH) \ - echo "Building runtime libraries and training compiler"; \ - $(MAKE) $(BASE_FLAGS_TO_PASS) $(RECURSE_FLAGS) all - @r=`${PWD_COMMAND}`; export r; \ s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ $(SET_LIB_PATH) \ - echo "Building feedback based compiler"; \ + echo "Building the feedback based compiler"; \ cd gcc && $(MAKE) $(GCC_FLAGS_TO_PASS) stagefeedback_build + @r=`${PWD_COMMAND}`; export r; \ + s=`cd $(srcdir); ${PWD_COMMAND}` ; export s; \ + $(SET_LIB_PATH) \ + echo "Building the runtime libraries"; \ + $(MAKE) $(BASE_FLAGS_TO_PASS) $(RECURSE_FLAGS) all .PHONY: cross cross: all-texinfo all-bison all-byacc all-binutils all-gas all-ld