From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25316 invoked by alias); 8 Jul 2004 19:51:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25301 invoked from network); 8 Jul 2004 19:51:12 -0000 Received: from unknown (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org with SMTP; 8 Jul 2004 19:51:12 -0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.12.10/8.12.10) with ESMTP id i68JlaSt031109; Thu, 8 Jul 2004 15:47:36 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i68JpBw29592; Thu, 8 Jul 2004 15:51:11 -0400 Received: from frothingslosh.sfbay.redhat.com (frothingslosh.sfbay.redhat.com [172.16.24.27]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i68JpAP19228; Thu, 8 Jul 2004 12:51:11 -0700 Received: from frothingslosh.sfbay.redhat.com (localhost.localdomain [127.0.0.1]) by frothingslosh.sfbay.redhat.com (8.12.10/8.12.10) with ESMTP id i68JpAQw020290; Thu, 8 Jul 2004 12:51:10 -0700 Received: (from rth@localhost) by frothingslosh.sfbay.redhat.com (8.12.10/8.12.10/Submit) id i68JpA7t020288; Thu, 8 Jul 2004 12:51:10 -0700 X-Authentication-Warning: frothingslosh.sfbay.redhat.com: rth set sender to rth@redhat.com using -f Date: Thu, 08 Jul 2004 21:15:00 -0000 From: Richard Henderson To: Paolo Bonzini Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Remove the postincrement queue Message-ID: <20040708195110.GC20150@redhat.com> Mail-Followup-To: Richard Henderson , Paolo Bonzini , gcc-patches@gcc.gnu.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SW-Source: 2004-07/txt/msg00832.txt.bz2 On Thu, Jul 08, 2004 at 04:35:24PM +0200, Paolo Bonzini wrote: > Unfortunately (but quite understandably), va_arg expanders are heavy > users of {pre,post}{in,de}crements, which means that this patch has > ramifications in backend code. The obvious solution is to expand > preincrements and predecrements manually, and for postincrements use > (x+N)-N; of course the real solution would be to transition these > backends to using gimplifiers for va_arg: these could well use the > now-banned tree codes, but this is well above my abilities. Hum. I'm not really fond of the brief scan of the changes you did here in the valist code. Most of them would need reverting to almost exactly what's there. Why don't we take care of this first? I'm sure the conversion is not above your abilities. r~