From: "H. J. Lu" <hjl@lucon.org>
To: Andrew Pinski <apinski@apple.com>
Cc: gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org,
Andrew Pinski <pinskia@physics.uc.edu>
Subject: Re: [PATCH] Re: 21 GCC HEAD regressions, 2 new, with your patch on 2004-07-07T22:45:18Z.
Date: Fri, 09 Jul 2004 07:10:00 -0000 [thread overview]
Message-ID: <20040709061744.GA29655@lucon.org> (raw)
In-Reply-To: <4C6A1D9B-D16D-11D8-BC99-00039351ED8A@apple.com>
On Thu, Jul 08, 2004 at 11:00:37PM -0700, Andrew Pinski wrote:
> >
> >It looks like we may need a undo_make_decl_one_only if we have to
> >change our mind like that.
>
> Yes and I was just creating one.
> Here is the patch which fixes the problem for me on
> powerpc-apple-darwin.
>
> OK? Bootstrapped on powerpc-apple-darwin.
>
> I have not added to the other targets which need the macro also.
> The C++ part and the other target support is needed for the 3.4 branch
> also.
>
> Thanks,
> Andrew Pinski
>
> ChangLog:
> * config/darwin-protos.h (darwin_make_decl_non_one_only): Prototype.
> * config/darwin.c (darwin_make_decl_non_one_only): Declare.
> * config/darwin.h (MAKE_DECL_NON_ONE_ONLY): Declare.
> * doc/tm.texi (MAKE_DECL_NON_ONE_ONLY): Document.
>
>
We need MAKE_DECL_NON_ONE_ONLY for all targets which define
MAKE_DECL_ONE_ONLY. It may look like
#ifndef MAKE_DECL_NON_ONE_ONLY
# ifdef MAKE_DECL_ONE_ONLY
#define MAKE_DECL_NON_ONE_ONLY(DECL) (DECL_WEAK (DECL) = 0)
# endif
#endif
H.J.
prev parent reply other threads:[~2004-07-09 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040709055003.GA29236@lucon.org>
2004-07-09 6:24 ` Andrew Pinski
2004-07-09 7:10 ` H. J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040709061744.GA29655@lucon.org \
--to=hjl@lucon.org \
--cc=apinski@apple.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=pinskia@physics.uc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).