From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-122032-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 16852 invoked by alias); 9 Jul 2004 06:17:46 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 16838 invoked from network); 9 Jul 2004 06:17:45 -0000
Received: from unknown (HELO rwcrmhc12.comcast.net) (216.148.227.85)
  by sourceware.org with SMTP; 9 Jul 2004 06:17:45 -0000
Received: from lucon.org ([24.6.43.109]) by comcast.net (rwcrmhc12) with ESMTP
          id <2004070906174501400lfnk0e>; Fri, 9 Jul 2004 06:17:45 +0000
Received: by lucon.org (Postfix, from userid 1000)
	id D81C164D13; Thu,  8 Jul 2004 23:17:44 -0700 (PDT)
Date: Fri, 09 Jul 2004 07:10:00 -0000
From: "H. J. Lu" <hjl@lucon.org>
To: Andrew Pinski <apinski@apple.com>
Cc: gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org,
	Andrew Pinski <pinskia@physics.uc.edu>
Subject: Re: [PATCH] Re: 21 GCC HEAD regressions, 2 new, with your patch on 2004-07-07T22:45:18Z.
Message-ID: <20040709061744.GA29655@lucon.org>
References: <20040709055003.GA29236@lucon.org> <4C6A1D9B-D16D-11D8-BC99-00039351ED8A@apple.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C6A1D9B-D16D-11D8-BC99-00039351ED8A@apple.com>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2004-07/txt/msg00890.txt.bz2

On Thu, Jul 08, 2004 at 11:00:37PM -0700, Andrew Pinski wrote:
> >
> >It looks like we may need a undo_make_decl_one_only if we have to
> >change our mind like that.
> 
> Yes and I was just creating one.
> Here is the patch which fixes the problem for me on 
> powerpc-apple-darwin.
> 
> OK? Bootstrapped on powerpc-apple-darwin.
> 
> I have not added to the other targets which need the macro also.
> The C++ part and the other target support is needed for the 3.4 branch 
> also.
> 
> Thanks,
> Andrew Pinski
> 
> ChangLog:
> 	* config/darwin-protos.h (darwin_make_decl_non_one_only): Prototype.
> 	* config/darwin.c (darwin_make_decl_non_one_only): Declare.
> 	* config/darwin.h (MAKE_DECL_NON_ONE_ONLY): Declare.
> 	* doc/tm.texi (MAKE_DECL_NON_ONE_ONLY): Document.
> 
> 

We need MAKE_DECL_NON_ONE_ONLY for all targets which define
MAKE_DECL_ONE_ONLY. It may look like

#ifndef MAKE_DECL_NON_ONE_ONLY
# ifdef MAKE_DECL_ONE_ONLY
#define MAKE_DECL_NON_ONE_ONLY(DECL) (DECL_WEAK (DECL) = 0)
# endif
#endif


H.J.