public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: fortran@gcc.gnu.org
Cc: "Tobias Schlüter" <tobias.schlueter@physik.uni-muenchen.de>,
	patch <gcc-patches@gcc.gnu.org>
Subject: Re: [gfortran] Fix PR 13201
Date: Fri, 09 Jul 2004 21:30:00 -0000	[thread overview]
Message-ID: <200407092153.09047.paul@codesourcery.com> (raw)
In-Reply-To: <40EF0064.90805@physik.uni-muenchen.de>

On Friday 09 July 2004 21:30, Tobias Schlüter wrote:
> My previous fixlet for PR 13201 didn't catch the general case of a
> parameter array not having a constant shape. This followup patch fixes
> that omission.
>
> Looking the patch over, I think a better name than 'constant shape' is
> probably called for. I'm open to suggestions how to concisely say
> 'explicit shape, determined at compile time by means of constants'. I
> will definitely enhance the comment in array.c.

The standard calls variables whose size is not known at compile time 
"automatic objects".  My suggested wording is:

"Parameter array '%s' at %L cannot be automatic or assumed shape"

Assumed size already triggers a different error elsewhere.

> Built and tested on i686-pc-linux.
>
> - Tobi
>
> 2004-07-09  Tobias Schlueter  <tobias.schlueter@physik.uni-muenchen.de>
>
> 	PR fortran/13201
> 	* resolve.c (resolve_symbol): Verify that the shape of a
> 	parameter array is not only explicit, but also constant.
> 	* array.c (gfc_is_constant_shape): New function.
> 	* gfortran.h (gfc_is_constant_shape): Add prototype.

Ok.

Paul

  reply	other threads:[~2004-07-09 20:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-09 21:13 Tobias Schlüter
2004-07-09 21:30 ` Paul Brook [this message]
2004-07-09 22:36   ` Tobias Schlüter
  -- strict thread matches above, loose matches on Subject: below --
2004-05-31 22:50 Tobias Schlüter
2004-06-08 23:54 ` Paul Brook
2004-06-09 14:00   ` Tobias Schlüter
2004-06-09 16:43     ` Jonathan Lennox
2004-06-09 16:57       ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200407092153.09047.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tobias.schlueter@physik.uni-muenchen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).