public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@physics.uc.edu>
To: mark@codesourcery.com (Mark Mitchell)
Cc: pinskia@physics.uc.edu (Andrew Pinski), gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Revert HJL's G++ generates local references to linkonce
Date: Tue, 13 Jul 2004 02:27:00 -0000	[thread overview]
Message-ID: <200407122231.i6CMVYR07163@tin.geop.uc.edu> (raw)
In-Reply-To: <40F3053F.4010303@codesourcery.com> from "Mark Mitchell" at Jul 12, 2004 02:40:15 PM

> >I figured out a better way of fixing this regression besides reverting the patch.
> >See <http://gcc.gnu.org/ml/gcc-patches/2004-07/msg00878.html>.
> >
> >Here is the updated patch which has been bootstrapped on powerpc-apple-darwin and fixes these
> >two regressions and also should fix the regressions on the other targets too unlike my previous patch
> >in the message above.
> >
> It seems to me like we ought to be able to determine  the linkage of a 
> symbol before we start fiddling with it, now that we do compilation on a 
> unit-at-a-time basis.  I can't find HJ's original test case anymore; 
> would you point me at that?

He did not post the testcase until after posting the patch and getting the ok:
http://gcc.gnu.org/ml/gcc-patches/2004-07/msg00637.html


> And, in the mean time, would you like to revert HJ's patch until we 
> figure out what we really want to do?

Ok, I reverted the patch for now.

Thanks,
Andrew Pinski

  reply	other threads:[~2004-07-12 22:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-09  6:19 Andrew Pinski
2004-07-09  7:15 ` Mark Mitchell
2004-07-13  0:37   ` Andrew Pinski
2004-07-13  1:20     ` Mark Mitchell
2004-07-13  2:27       ` Andrew Pinski [this message]
2004-07-13  5:56         ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200407122231.i6CMVYR07163@tin.geop.uc.edu \
    --to=pinskia@physics.uc.edu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mark@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).