From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31613 invoked by alias); 15 Jul 2004 00:01:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31605 invoked from network); 15 Jul 2004 00:01:53 -0000 Received: from unknown (HELO mail.cs.umass.edu) (128.119.243.168) by sourceware.org with SMTP; 15 Jul 2004 00:01:53 -0000 Received: from localhost (IDENT:7JkUEXnEieaO47F8BYl5vL/dJDPYweSf@loki.cs.umass.edu [128.119.243.168]) by mail.cs.umass.edu (8.12.11/8.12.5) with ESMTP id i6F01rdf015366; Wed, 14 Jul 2004 20:01:53 -0400 Date: Thu, 15 Jul 2004 10:30:00 -0000 Message-Id: <20040714.200146.74752437.kazu@cs.umass.edu> To: SherryS@KPITCummins.com Cc: gcc-patches@gcc.gnu.org Subject: Re: Unreviewed Patch [H8/300] : Patch for -mno-exr option in case of function with "monitor" attribute From: Kazu Hirata In-Reply-To: <4A1BE23A7B777442B60F4B4916AE0F13022B51B9@sohm.kpit.com> References: <4A1BE23A7B777442B60F4B4916AE0F13022B51B9@sohm.kpit.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg01510.txt.bz2 Hi Sherry, > The monitor function can accept parameters and return values. The > monitor attribute requires the > "h8300_current_function_monitor_function_p()" to be declared. Why? Neither the current source code nor your patch has a call to h8300_current_function_monitor_function_p. How is it called? I am wondering if you have missed a hunk or two when you submitted your patch. > If this is not done the monitor function will be treated similar to > interrupt function which cannot accept parameters or return values. > The patch http://gcc.gnu.org/ml/gcc-patches/2004-06/msg02495.html > implements the behavior similar to IAR compiler. We have done the > debugging in native gdb and it was found that it uses the > "h8300_current_function_monitor_function_p()" whenever the monitor > attribute is used. Are you defining h8300_current_function_monitor_function_p so that you can call it from gdb? Kazu Hirata