public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Steven Bosscher <stevenb@suse.de>
To: Revital Eres <ERES@il.ibm.com>, gcc-patches@gcc.gnu.org
Cc: Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz>
Subject: Re: [Patch] Splitting memory references during unrolling (resubmission)
Date: Mon, 09 Aug 2004 07:19:00 -0000	[thread overview]
Message-ID: <200408090916.47231.stevenb@suse.de> (raw)
In-Reply-To: <200408090914.39979.stevenb@suse.de>

On Monday 09 August 2004 09:14, Steven Bosscher wrote:
> >   if ((REG_P (dest) || GET_MODE (dest) == SUBREG)
> >       && GET_CODE (src) == MEM)
>
> I believe you want GET_CODE here, not GET_MODE.  And when it is a
> SUBREG, you probably want to make sure that SUBREG_REG is a REG.  And
> you can use MEM_P now instead of GET_CODE (src) == MEM.
> So the condition should be:
>
>   if ((REG_P (dest)
>        || (GET_MODE (dest) == SUBREG
Aargh            ^

> 	   && REG_P (SUBREG_REG (dest))))
>       && MEM_P (src))

Never c&p a bad hunk.

  if ((REG_P (dest)
       || (GET_CODE (dest) == SUBREG
	   && REG_P (SUBREG_REG (dest))))
      && MEM_P (src))

Time for instant self-punishment.

Gr.
Steven


  reply	other threads:[~2004-08-09  7:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-09  7:03 Revital Eres
2004-08-09  7:15 ` Steven Bosscher
2004-08-09  7:19   ` Steven Bosscher [this message]
2004-08-21 16:41 ` Zdenek Dvorak
2004-09-02  7:08   ` Revital Eres
2004-08-18 16:39 Revital Eres
2004-10-14 13:14 Revital Eres
2004-10-15  3:48 ` David Edelsohn
2004-11-18 14:23   ` Revital Eres
2004-11-18 15:46     ` David Edelsohn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200408090916.47231.stevenb@suse.de \
    --to=stevenb@suse.de \
    --cc=ERES@il.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rakdver@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).