From: Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz>
To: Jakub Jelinek <jakub@redhat.com>
Cc: dnovillo@redhat.com, rth@redhat.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PR tree-optimization/17724 (take 2)
Date: Fri, 15 Oct 2004 19:24:00 -0000 [thread overview]
Message-ID: <20041015192452.GA6480@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20041010145645.GZ31909@devserv.devel.redhat.com>
Hello,
> On Sat, Oct 09, 2004 at 11:00:00AM +0200, Zdenek Dvorak wrote:
> > this does not seem to be the right fix to me:
> >
> > 1) Change to delete_unreachable_blocks is not necessary. As long as
> > dominators are set correctly before delete_unreachable_blocks,
> > they are also set correctly after it (since removal of unreachable
> > blocks cannot affect any path from entry to basic block bb, and
> > immediate dominator is determined from exactly these paths).
>
> Are you sure that in all other cases where some basic blocks become
> unreachable code that removes the edge ensures that dominators are freed
> or recomputed for all basic blocks where idom(bb) could change?
not completely, of course. Verify_dominators that is able to catch
such problems is run on several places, so I am fairly sure we update
dominators correctly most of the time, but of course there may be
some more buggy places.
Zdenek
prev parent reply other threads:[~2004-10-15 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041009082440.GB22455@atrey.karlin.mff.cuni.cz>
2004-10-09 9:23 ` [PATCH] Fix PR tree-optimization/17724 Zdenek Dvorak
2004-10-10 15:20 ` [PATCH] Fix PR tree-optimization/17724 (take 2) Jakub Jelinek
2004-10-12 17:59 ` Diego Novillo
2004-10-15 19:24 ` Zdenek Dvorak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041015192452.GA6480@atrey.karlin.mff.cuni.cz \
--to=rakdver@atrey.karlin.mff.cuni.cz \
--cc=dnovillo@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).