public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kazu Hirata <kazu@cs.umass.edu>
To: gcc-patches@gcc.gnu.org
Subject: [patch] expr.c: Remove an obsolete comment.
Date: Sun, 17 Oct 2004 16:21:00 -0000	[thread overview]
Message-ID: <20041017.120318.102577353.kazu@cs.umass.edu> (raw)

Hi,

Attached is a patch to remove an obsolete comment.

This comment does not seem to describe any code.  I looked at
expand_assignment, which handles MODIFY_EXPR, but I didn't find any
code that would be described by this comment.

OK to apply?

Kazu Hirata

2004-10-17  Kazu Hirata  <kazu@cs.umass.edu>

	* expr.c (expand_expr_real_1): Remove an obsolete comment.

Index: expr.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/expr.c,v
retrieving revision 1.726
diff -u -r1.726 expr.c
--- expr.c	3 Oct 2004 22:50:18 -0000	1.726
+++ expr.c	17 Oct 2004 15:55:49 -0000
@@ -8064,14 +8064,6 @@
 
     case MODIFY_EXPR:
       {
-	/* If lhs is complex, expand calls in rhs before computing it.
-	   That's so we don't compute a pointer and save it over a
-	   call.  If lhs is simple, compute it first so we can give it
-	   as a target if the rhs is just a call.  This avoids an
-	   extra temp and copy and that prevents a partial-subsumption
-	   which makes bad code.  Actually we could treat
-	   component_ref's of vars like vars.  */
-
 	tree lhs = TREE_OPERAND (exp, 0);
 	tree rhs = TREE_OPERAND (exp, 1);
 

             reply	other threads:[~2004-10-17 16:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-17 16:21 Kazu Hirata [this message]
2004-10-17 17:23 ` Kazu Hirata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041017.120318.102577353.kazu@cs.umass.edu \
    --to=kazu@cs.umass.edu \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).