From: Jan Hubicka <hubicka@ucw.cz>
To: Roger Sayle <roger@eyesopen.com>
Cc: Eric Botcazou <ebotcazou@libertysurf.fr>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PR middle-end/17813
Date: Sun, 17 Oct 2004 02:20:00 -0000 [thread overview]
Message-ID: <20041017012841.GF14689@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <Pine.LNX.4.44.0410161753300.15471-100000@www.eyesopen.com>
>
> On Sat, 16 Oct 2004, Eric Botcazou wrote:
> > 2004-10-16  Eric Botcazou  <ebotcazou@libertysurf.fr>
> >
> > PR middle-end/17813
> > * explow.c (emit_stack_save): Emit pending stack adjustments.
> > (emit_stack_restore): Likewise.
>
>
> This is OK for mainline. A slight improvement might be to add a new
> ignore_pending_stack_adjust function (like clear_pending_stack_adjust)
> that resets stack_pointer_delta and pending_stack_adjust to zero, and
> call that in emit_stack_restore. Currently, we'll emit a "dead" stack
> adjustment immediately prior to restoring the stack pointer, and then
> leave it to the RTL optimizers to clean up. All we really need to do
> is flush the "memory" of the pending adjustment.
RTL optimizers are not terribly smart about optimizing stack
adjustments. WOuld be possible to double check if they are really
elliminated?
>
>
> It's also not clear whether the two builtins __builtin_stack_save and
> __builtin_stack_restore need to be documented in extend.texi, or if
> they're intended purely as internal placeholders. Zdenek?
For purely internal builtins we probably should have something
preventing frontend from recognizing them in the input source so user
can't confuse us.
Honza
>
> Roger
> --
next prev parent reply other threads:[~2004-10-17 1:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-16 21:22 Eric Botcazou
2004-10-17 1:28 ` Roger Sayle
2004-10-17 2:20 ` Jan Hubicka [this message]
2004-10-17 13:51 ` Eric Botcazou
2004-10-17 17:07 ` Roger Sayle
2004-10-17 9:58 ` Matthias Klose
2004-10-17 11:55 ` Eric Botcazou
2004-10-17 12:03 ` Matthias Klose
2004-10-17 17:57 ` Eric Botcazou
2004-10-17 19:40 ` Daniel Jacobowitz
2004-10-18 15:44 ` Eric Botcazou
2004-10-18 15:44 ` Arnaud Charlet
2004-10-18 16:30 ` Eric Botcazou
2004-10-18 12:16 ` Eric Botcazou
2004-10-18 22:11 ` Eric Botcazou
2004-10-17 18:48 Richard Kenner
2004-10-18 8:22 ` Eric Botcazou
2004-10-18 14:56 Richard Kenner
2004-10-18 16:03 ` Eric Botcazou
2004-10-18 17:18 Richard Kenner
2004-10-18 20:56 ` Eric Botcazou
2004-10-18 21:17 ` Laurent GUERBY
2004-10-18 21:04 Richard Kenner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041017012841.GF14689@atrey.karlin.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=ebotcazou@libertysurf.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=roger@eyesopen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).