From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11318 invoked by alias); 18 Oct 2004 14:25:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11275 invoked from network); 18 Oct 2004 14:25:34 -0000 Received: from unknown (HELO atrey.karlin.mff.cuni.cz) (195.113.31.123) by sourceware.org with SMTP; 18 Oct 2004 14:25:34 -0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 29025) id 86F404B43CE; Mon, 18 Oct 2004 16:25:33 +0200 (CEST) Date: Mon, 18 Oct 2004 14:28:00 -0000 From: Zdenek Dvorak To: David Edelsohn Cc: gcc-patches@gcc.gnu.org Subject: Re: Patch ping ^ 2 Message-ID: <20041018142533.GA29231@atrey.karlin.mff.cuni.cz> References: <20041018082206.GA12587@atrey.karlin.mff.cuni.cz> <200410181352.i9IDqwV18200@makai.watson.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410181352.i9IDqwV18200@makai.watson.ibm.com> User-Agent: Mutt/1.5.6i X-SW-Source: 2004-10/txt/msg01478.txt.bz2 Hello, > > 1) Unless your patch to make voperands represent output dependences again > > (http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01437.html) gets into > > mainline, the rewrite of store motion > > (http://gcc.gnu.org/ml/gcc-patches/2004-09/msg01120.html) is the best > > choice. > > Regardless whether Dan's patch gets approved for mainline, the > original, unmodified patch is taking GCC in the wrong direction and should > not be accepted. you cannot be serious. Unless the msg01437.html patch is accepted, the rewrite is the only sane possibility how to solve PR 17133 (serious misscompilations...) And why do you assume that the direction in that the patch takes it is wrong? It is the way at least one other compiler (LLVM) uses. It is clean and very easy to understand and extend. Also once the msg01437.html is accepted (which it should, at least for 4.1, although I think it is a bit too intrusive for 4.0), it is trivial to make it take advantage of SSA form for virtual operands. Zdenek