From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27668 invoked by alias); 19 Oct 2004 22:04:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27660 invoked from network); 19 Oct 2004 22:04:03 -0000 Received: from unknown (HELO atrey.karlin.mff.cuni.cz) (195.113.31.123) by sourceware.org with SMTP; 19 Oct 2004 22:04:03 -0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 29025) id 0A48A4B40C5; Wed, 20 Oct 2004 00:04:03 +0200 (CEST) Date: Tue, 19 Oct 2004 22:06:00 -0000 From: Zdenek Dvorak To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org, Richard Henderson Subject: Re: [patch] for PR 18040 Message-ID: <20041019220403.GA31457@atrey.karlin.mff.cuni.cz> References: <20041017191535.GA21330@atrey.karlin.mff.cuni.cz> <20041019213303.GC19976@redhat.com> <20041019215509.GA30134@atrey.karlin.mff.cuni.cz> <72CE1032-221A-11D9-B4B8-000A95D692F4@physics.uc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <72CE1032-221A-11D9-B4B8-000A95D692F4@physics.uc.edu> User-Agent: Mutt/1.5.6i X-SW-Source: 2004-10/txt/msg01638.txt.bz2 Hello, > >>On Sun, Oct 17, 2004 at 09:15:35PM +0200, Zdenek Dvorak wrote: > >>> PR tree-optimization/18040 > >>> * tree-gimple.c (is_gimple_component): New function. > >>> (is_gimple_addressable, get_base_address): Use is_gimple_component. > >> > >>I think we should simply remove the casts from handled_component_p. > > > >then it would also be necessary to remove other superfluous entries > >from > >it that are not recognized as gimple components (BIT_FIELD_REF and > >NON_LVALUE_EXPR). I do not care for later, but removing former seems > >likely to break other code. > > BIT_FIELD_REF should be handled the same way as COMPONENT_REF I think. not according to gimple grammar (and also it does not make sense to have BIT_FIELD_REF's nested). Zdenek