From: Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz>
To: Zack Weinberg <zack@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [patch] Partial fix for PR 18048
Date: Mon, 25 Oct 2004 23:02:00 -0000 [thread overview]
Message-ID: <20041025225942.GB1477@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <877jpee7ci.fsf@codesourcery.com>
Hello,
> >> While this is a good conceptual change, this is not the appropriate
> >> way to do it. You are creating trees just to get fold() to do
> >> arithmetic for you, which wastes memory,
> >
> > no, I am not. 0 is a shared constant, so no allocation for
> > build_int_cst_type (niter_type, 0)), and EXEC_UNARY is
> > nondestructive_fold_unary_to_constant that also does not build any
> > trees (except for the result, of course).
>
> That's nice. You're still doing unnecessary work.
yes, however creating duplicated code just for purpose of saving a very
small amount of time on place that clearly is not critical does not
seem very useful to me. I.e. I would rather stick with the simple 2
lines solution that is a bit suboptimal, rather than to implement your
20-lines one.
Of course if you want to do the change, you won't spoil anything by it.
Zdenek
next prev parent reply other threads:[~2004-10-25 22:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-24 13:16 Zdenek Dvorak
2004-10-24 17:30 ` Andrew Pinski
2004-10-24 17:57 ` Zdenek Dvorak
2004-10-25 18:15 ` Zack Weinberg
2004-10-25 22:55 ` Zdenek Dvorak
2004-10-25 23:01 ` Zack Weinberg
2004-10-25 23:02 ` Zdenek Dvorak [this message]
2004-10-25 23:10 ` Zdenek Dvorak
2004-10-27 15:38 ` Zdenek Dvorak
2004-10-27 16:22 ` Andrew Pinski
2004-10-27 16:24 ` Zdenek Dvorak
2004-10-27 17:13 ` Dale Johannesen
2004-10-27 20:31 ` Zdenek Dvorak
2004-10-27 19:00 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041025225942.GB1477@atrey.karlin.mff.cuni.cz \
--to=rakdver@atrey.karlin.mff.cuni.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=zack@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).