From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26163 invoked by alias); 29 Apr 2005 10:27:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25519 invoked from network); 29 Apr 2005 10:26:41 -0000 Received: from unknown (HELO province.act-europe.fr) (212.157.227.214) by sourceware.org with SMTP; 29 Apr 2005 10:26:41 -0000 Received: by province.act-europe.fr (Postfix, from userid 525) id D05D8B84EA; Fri, 29 Apr 2005 12:26:40 +0200 (CEST) Date: Fri, 29 Apr 2005 10:27:00 -0000 From: Arnaud Charlet To: John David Anglin Cc: gcc-patches@gcc.gnu.org, laurent@guerby.net Subject: Re: [patch] Add Ada tasking support for hppa-unknown-linux-gnu (take 2) Message-ID: <20050429102640.GA34244@adacore.com> References: <200504061637.j36GbcjC005960@hiauly1.hia.nrc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200504061637.j36GbcjC005960@hiauly1.hia.nrc.ca> User-Agent: Mutt/1.4.2.1i X-SW-Source: 2005-04/txt/msg02944.txt.bz2 > Here is take 2. The changes from the previous version are all to the > file s-osinte-linux-hppa.ads: BTW, I missed the approval of this patch, could you point me to the email approving this change ? > 1) Definition of struct_sigaction corrected, > 2) Definition of SA_SIGINFO corrected, > 3) sigset_t changed to array of unsigned_long. Could you explain why you changed sigset_t definition ? Also, the alignment for atomic_lock_t seems wrong to me: you are using 8 * 16, but the alignment is specified in *bytes*, not bits (a usual confusion), so this value seems very high to me. Didn't you mean 16 instead ? Thanks for checking. Also, there are really too many undesirable duplications between s-osinte-linux*.ads files, which is a maintenance issue, so I'd rather see a clean up in this area (such as moving target specific bits such as signal numbers in a separate file). Arno