From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32045 invoked by alias); 30 Apr 2005 00:10:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31769 invoked from network); 30 Apr 2005 00:10:40 -0000 Received: from unknown (HELO hiauly1.hia.nrc.ca) (132.246.100.193) by sourceware.org with SMTP; 30 Apr 2005 00:10:40 -0000 Received: from hiauly1.hia.nrc.ca (hiauly1.hia.nrc.ca [127.0.0.1] (may be forged)) by hiauly1.hia.nrc.ca (8.12.9-20030917/8.12.9) with ESMTP id j3U0AchF017666; Fri, 29 Apr 2005 20:10:38 -0400 (EDT) Received: (from dave@localhost) by hiauly1.hia.nrc.ca (8.12.9-20030917/8.12.9/Submit) id j3U0Ab2n017665; Fri, 29 Apr 2005 20:10:37 -0400 (EDT) Message-Id: <200504300010.j3U0Ab2n017665@hiauly1.hia.nrc.ca> Subject: Re: [patch] Add Ada tasking support for hppa-unknown-linux-gnu (take 2) To: charlet@adacore.com (Arnaud Charlet) Date: Sat, 30 Apr 2005 00:14:00 -0000 From: "John David Anglin" Cc: gcc-patches@gcc.gnu.org, laurent@guerby.net In-Reply-To: <20050429102640.GA34244@adacore.com> from "Arnaud Charlet" at Apr 29, 2005 12:26:40 pm MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2005-04/txt/msg03021.txt.bz2 > > 3) sigset_t changed to array of unsigned_long. > > Could you explain why you changed sigset_t definition ? >From bits/sigset.h: # define _SIGSET_NWORDS (1024 / (8 * sizeof (unsigned long int))) typedef struct { unsigned long int __val[_SIGSET_NWORDS]; } __sigset_t; > Also, the alignment for atomic_lock_t seems wrong to me: you are using > 8 * 16, but the alignment is specified in *bytes*, not bits (a usual > confusion), so this value seems very high to me. Didn't you mean 16 > instead ? The required alignment is 16 bytes. Dave -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602)