public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@gcc.gnu.org>
To: Diego Novillo <dnovillo@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Fix PR 25886.  Convert OMP_CLAUSE_* into sub-codes.
Date: Wed, 25 Jan 2006 18:26:00 -0000	[thread overview]
Message-ID: <20060125180817.GB24940@redhat.com> (raw)
In-Reply-To: <43D7B83A.3060802@redhat.com>

On Wed, Jan 25, 2006 at 12:41:14PM -0500, Diego Novillo wrote:
> +unsigned char omp_clause_num_ops[] =

const

> +const char *omp_clause_code_name[] =

const char * const

> +      return (sizeof (struct tree_omp_clause)
> +	      + (omp_clause_num_ops[OMP_CLAUSE_CODE (node)] - 1)
> +	        * sizeof (char *));

char *?  should be tree, surely.

> +#ifdef GATHER_STATISTICS
> +  tree_node_counts[(int) x_kind]++;
> +  tree_node_sizes[(int) x_kind] += size;
> +#endif

x_kind undefined.

Otherwise ok.


r~

  reply	other threads:[~2006-01-25 18:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-25 18:05 Diego Novillo
2006-01-25 18:26 ` Richard Henderson [this message]
2006-01-25 19:19   ` Diego Novillo
2006-01-26  3:10   ` Diego Novillo
2006-01-26  8:03     ` Andreas Tobler
     [not found]     ` <997433FE-17D0-47FB-B9EF-353CD7D9E07A@opendarwin.org>
2006-01-26 12:56       ` Diego Novillo
2021-08-31 18:51 ` Simplify 'gcc/tree.c:walk_tree_1' handling of 'OMP_CLAUSE' (was: Fix PR 25886. Convert OMP_CLAUSE_* into sub-codes.) Thomas Schwinge
2021-09-01  9:49   ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060125180817.GB24940@redhat.com \
    --to=rth@gcc.gnu.org \
    --cc=dnovillo@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).