From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1005 invoked by alias); 25 Jan 2006 18:08:28 -0000 Received: (qmail 995 invoked by uid 22791); 25 Jan 2006 18:08:26 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Jan 2006 18:08:22 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k0PI8KS9020010 for ; Wed, 25 Jan 2006 13:08:20 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k0PI8J106327; Wed, 25 Jan 2006 13:08:19 -0500 Received: from ballpeen.sfbay.redhat.com (ballpeen.sfbay.redhat.com [172.16.24.33]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k0PI8IhD024796; Wed, 25 Jan 2006 13:08:18 -0500 Received: from ballpeen.sfbay.redhat.com (ballpeen.sfbay.redhat.com [127.0.0.1]) by ballpeen.sfbay.redhat.com (8.13.4/8.13.1) with ESMTP id k0PI8Hxq025009; Wed, 25 Jan 2006 10:08:17 -0800 Received: (from rth@localhost) by ballpeen.sfbay.redhat.com (8.13.4/8.13.4/Submit) id k0PI8HHE025008; Wed, 25 Jan 2006 10:08:17 -0800 Date: Wed, 25 Jan 2006 18:26:00 -0000 From: Richard Henderson To: Diego Novillo Cc: gcc-patches@gcc.gnu.org Subject: Re: Fix PR 25886. Convert OMP_CLAUSE_* into sub-codes. Message-ID: <20060125180817.GB24940@redhat.com> Mail-Followup-To: Richard Henderson , Diego Novillo , gcc-patches@gcc.gnu.org References: <43D7B83A.3060802@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43D7B83A.3060802@redhat.com> User-Agent: Mutt/1.4.2.1i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2006-01/txt/msg01752.txt.bz2 On Wed, Jan 25, 2006 at 12:41:14PM -0500, Diego Novillo wrote: > +unsigned char omp_clause_num_ops[] = const > +const char *omp_clause_code_name[] = const char * const > + return (sizeof (struct tree_omp_clause) > + + (omp_clause_num_ops[OMP_CLAUSE_CODE (node)] - 1) > + * sizeof (char *)); char *? should be tree, surely. > +#ifdef GATHER_STATISTICS > + tree_node_counts[(int) x_kind]++; > + tree_node_sizes[(int) x_kind] += size; > +#endif x_kind undefined. Otherwise ok. r~