From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17552 invoked by alias); 24 Jun 2006 15:33:36 -0000 Received: (qmail 17251 invoked by uid 22791); 24 Jun 2006 15:33:36 -0000 X-Spam-Check-By: sourceware.org Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.208.78.105) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 24 Jun 2006 15:33:34 +0000 Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.13.7/8.13.7) with ESMTP id k5OFWIYc058021; Sat, 24 Jun 2006 08:32:18 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.13.7/8.13.7/Submit) id k5OFWB2l058020; Sat, 24 Jun 2006 08:32:11 -0700 (PDT) (envelope-from sgk) Date: Sat, 24 Jun 2006 15:35:00 -0000 From: Steve Kargl To: Paul Thomas Cc: "'fortran@gcc.gnu.org'" , patch Subject: Re: [Patch, fortran] Message-ID: <20060624153211.GA58005@troutmask.apl.washington.edu> References: <449C20DA.1060503@wanadoo.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <449C20DA.1060503@wanadoo.fr> User-Agent: Mutt/1.4.2.1i Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2006-06/txt/msg01329.txt.bz2 + if (type == BT_LOGICAL && cp->low->expr_type == EXPR_CONSTANT) + { + if (cp->low->value.logical & seen_logical) Do you want & or && here? + { + gfc_error ("constant logical value in CASE statement " + "is repeated at %L", + &cp->low->where); + t = FAILURE; + break; + } Otherwise, the patch is OK. -- Steve