From: Richard Henderson <rth@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix _Unwind_Context backward compatibility issues
Date: Wed, 03 Jan 2007 18:07:00 -0000 [thread overview]
Message-ID: <20070103180649.GA29734@redhat.com> (raw)
In-Reply-To: <20061228204040.GD29911@devserv.devel.redhat.com>
On Thu, Dec 28, 2006 at 03:40:41PM -0500, Jakub Jelinek wrote:
> Perhaps to be even more compatible even with older GCC 4.2 (plus
> all the 4.1 branches where this has been backported) unwinders,
> _Unwind_Context could be...
I'm ok with the first patch, where this is not done. While you're
preserving the layout in the second patch, you're not preserving
the values stuck into, or read from, those fields.
Really, this is all being done to cater to A Well Known Commercial
Program, whose authors ought to be hit with a clue bat. You've
done an admirable job working around their brokenness. I think it
would be a bit over the top to try to really preserve the field
values as the second patch would have to do. Particularly since
this doesn't seem to be necessary for a known case.
r~
prev parent reply other threads:[~2007-01-03 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 20:46 Jakub Jelinek
2006-12-29 6:54 ` [PATCH]: for Score backend liqin
2007-01-04 1:30 ` liqin
2007-01-08 4:53 ` liqin
2007-01-03 18:07 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070103180649.GA29734@redhat.com \
--to=rth@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).