From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29790 invoked by alias); 7 Jan 2007 16:43:07 -0000 Received: (qmail 29774 invoked by uid 22791); 7 Jan 2007 16:43:06 -0000 X-Spam-Check-By: sourceware.org Received: from warsl404pip5.highway.telekom.at (HELO email.aon.at) (195.3.96.77) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 07 Jan 2007 16:43:00 +0000 Received: (qmail 7315 invoked from network); 7 Jan 2007 16:42:56 -0000 Received: from m855p008.adsl.highway.telekom.at (HELO s37.loc) ([62.47.138.200]) (envelope-sender ) by smarthub78.highway.telekom.at (qmail-ldap-1.03) with SMTP for ; 7 Jan 2007 16:42:56 -0000 Received: from cow by s37.loc with local (Exim 4.63) (envelope-from ) id 1H3b8W-0006ro-Rd; Sun, 07 Jan 2007 17:44:44 +0100 Date: Sun, 07 Jan 2007 16:43:00 -0000 From: Bernhard Fischer To: Steve Kargl Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [patch, fortran] PR27698 - Add diagnostic message for invalid names Message-ID: <20070107164444.GF17577@aon.at> References: <20070103165049.GA16663@aon.at> <20070104050250.GA32508@troutmask.apl.washington.edu> <20070104101201.GC28746@aon.at> <20070105061332.GB43628@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070105061332.GB43628@troutmask.apl.washington.edu> User-Agent: Mutt/1.5.13 (2006-08-11) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-01/txt/msg00511.txt.bz2 On Thu, Jan 04, 2007 at 10:13:32PM -0800, Steve Kargl wrote: >On Thu, Jan 04, 2007 at 11:12:01AM +0100, Bernhard Fischer wrote: >> On Wed, Jan 03, 2007 at 09:02:50PM -0800, Steve Kargl wrote: >> >On Wed, Jan 03, 2007 at 05:50:49PM +0100, Bernhard Fischer wrote: >> >> :ADDPATCH fortran: >> >> >> >> According to 3.2.1, a name is >> >> letter [alphanumeric-character]... >> >> >> >> While we did reject invalid names, this PR wanted to have a diagnostic >> >> message to be printed along rejecting the invalid name. >> >> >> >> The attached patch adds this diagnostic message, adds one testcase to >> >> expect the newly added error message and adjusts testcases that trigger >> >> the new error. >> >> >> > >> >Why is do_iterator.f90 trigger the patch? Is this a illegal code triggering >> >the wrong error message? >> >> do_iterator.f90 is illegal code for which an error is thrown ("cannot be >> redefined inside loop beginning at") and then a different matcher >> (trying 'READ(5,*) I' as a name) is tried. > >OK, I understand the change now. Please, commit the patch. Applied to trunk. Thanks!