public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Rask Ingemann Lambertsen <rask@sygehus.dk>
To: gcc-patches@gcc.gnu.org
Cc: "Joseph S. Myers" <joseph@codesourcery.com>
Subject: [PATCH] PR/target 30370 powerpc-unknown-eabispe can't build libgcc2
Date: Mon, 08 Jan 2007 19:45:00 -0000	[thread overview]
Message-ID: <20070108194529.GC2384@sygehus.dk> (raw)

   At some point after the GCC 4.1.1 release, libgcc2 stopped building for
powerpc-unknown-eabispe. It is currently broken on the GCC 4.1 and 4.2
branches while GCC 4.3 was fixed recently by the toplevel libgcc changes.

   The cause of the problem is a typo in the condition for using
128-bit long double, meaning that all powerpc targets will using it, where
the intention was that only GNU targets should use 128-bit long double. In
addition to fixing this, at Joseph's suggestion, gnu*spe targets will also
be exempt from building libgcc with -mlong-double-128 because it just isn't
supported yet. This might fix PR/target 30259 (ICE building libgcc2 on
powerpc-unknown-linux-gnuspe) also.

   I built and tested the GCC 4.2 branch with the patch. Testresults are at
<URL:http://gcc.gnu.org/ml/gcc-testresults/2007-01/msg00350.html>. I
investigated two of the execution failures, both of which turned out to be
'illegal instruction', so something isn't right with the simulator.

   (I tried to build Java, Fortran and ObjC too, but their support libraries
libgfortran, boehm-gc and libffi won't configure on targets like this one
which can't link an executable without additional options.)

   I'm building and testing on the GCC 4.1 branch and will report the
results tomorrow, I expect.

   Since this patch will also affect powerpc-unknown-linux-gnuspe, I'd like
someone to test it on that target also. Joseph?

ChangeLog
2007-01-08  Rask Ingemann Lambertsen  <rask@sygehus.dk>
	    Joseph S. Myers <joseph@codesourcery.com>

	PR target/30370
	* config/rs6000/t-ppccomm (TARGET_LIBGCC2_CFLAGS): Fix condition for
	using 128-bit long double when compiling libgcc2.

Index: config/rs6000/t-ppccomm
===================================================================
--- config/rs6000/t-ppccomm	(revision 120546)
+++ config/rs6000/t-ppccomm	(working copy)
@@ -11,7 +11,8 @@
 tramp.S: $(srcdir)/config/rs6000/tramp.asm
 	cat $(srcdir)/config/rs6000/tramp.asm > tramp.S
 
-ifneq (,$findstring gnu,$(target))
+ifneq (,$(findstring gnu,$(target)))
+ifeq (,$(findstring spe,$(target)))
 TARGET_LIBGCC2_CFLAGS += -specs=ldblspecs
 
 SHLIB_MAPFILES += $(srcdir)/config/rs6000/libgcc-ppc-glibc.ver
@@ -22,6 +23,7 @@
 ldblspecs: specs
 	sed -e '/cc1_options/{ n; s/$$/ %{!msoft-float:-mlong-double-128}/; }' < specs > $@
 endif
+endif
 
 # Switch synonyms
 MULTILIB_MATCHES_ENDIAN	= mlittle=mlittle-endian mbig=mbig-endian

-- 
Rask Ingemann Lambertsen

             reply	other threads:[~2007-01-08 19:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-08 19:45 Rask Ingemann Lambertsen [this message]
2007-01-08 22:38 ` Joseph S. Myers
2007-01-08 23:44 ` David Edelsohn
2007-01-09 16:56   ` Rask Ingemann Lambertsen
2007-02-03 18:11 ` Rask Ingemann Lambertsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070108194529.GC2384@sygehus.dk \
    --to=rask@sygehus.dk \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).