public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* PATCH: PR target/31380: Typo in gcc/config/i386/sse.md
@ 2007-03-28  4:29 H. J. Lu
  0 siblings, 0 replies; 2+ messages in thread
From: H. J. Lu @ 2007-03-28  4:29 UTC (permalink / raw)
  To: gcc-patches; +Cc: grigory_zagorodnev

We should use UMIN, not UMAX, for uminv16qi3. Is this OK for 4.3,
4.2 and 4.1?


H.J.
----
2007-03-27  Grigory Zagorodnev <grigory_zagorodnev@linux.intel.com>

	PR target/31380
	* config/i386/sse.md (uminv16qi3): Use UMIN instead of UMAX.

--- gcc/config/i386/sse.md.typo	2007-03-27 06:40:27.000000000 -0700
+++ gcc/config/i386/sse.md	2007-03-27 19:01:18.000000000 -0700
@@ -3249,7 +3249,7 @@
 	(umin:V16QI (match_operand:V16QI 1 "nonimmediate_operand" "")
 		    (match_operand:V16QI 2 "nonimmediate_operand" "")))]
   "TARGET_SSE2"
-  "ix86_fixup_binary_operands_no_copy (UMAX, V16QImode, operands);")
+  "ix86_fixup_binary_operands_no_copy (UMIN, V16QImode, operands);")
 
 (define_insn "*uminv16qi3"
   [(set (match_operand:V16QI 0 "register_operand" "=x")

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: PR target/31380: Typo in gcc/config/i386/sse.md
@ 2007-03-28  8:28 Uros Bizjak
  0 siblings, 0 replies; 2+ messages in thread
From: Uros Bizjak @ 2007-03-28  8:28 UTC (permalink / raw)
  To: GCC Patches; +Cc: H. J. Lu, grigory_zagorodnev

Hello!

> 2007-03-27  Grigory Zagorodnev <grigory_zagorodnev@linux.intel.com>

>	PR target/31380
>	* config/i386/sse.md (uminv16qi3): Use UMIN instead of UMAX.

This is obvious typo. The patch is OK for mainline (it is also OK for
4.1 and 4.2, but please wait a couple of days before committing it to
branches if RM has any objections).

BTW: You didn't say where it was bootstrapped and how it was tested.

Thanks,
Uros.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-03-28  7:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-28  4:29 PATCH: PR target/31380: Typo in gcc/config/i386/sse.md H. J. Lu
2007-03-28  8:28 Uros Bizjak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).